Local Deployer - Docker - Network property is being ignored

[lukas-schw]

When using the local deployer to deploy a containerized application the network property for Docker (deployer.*.local.docker.network) is being ignored.
The cause for this seems to be, that in the DockerCommandBuilder constructor the dockerNetwork is set:

spring-cloud-deployer/spring-cloud-deployer-local/src/main/java/org/springframework/cloud/deployer/spi/local/DockerCommandBuilder.java

Lines 64 to 66 in 062e8cb

	public DockerCommandBuilder(String dockerNetwork) {
	this.dockerNetwork = dockerNetwork;
	}

and then reused when building the execution command:

spring-cloud-deployer/spring-cloud-deployer-local/src/main/java/org/springframework/cloud/deployer/spi/local/DockerCommandBuilder.java

Lines 104 to 107 in 062e8cb

	if (StringUtils.hasText(this.dockerNetwork)) {
	commands.add("--network");
	commands.add(this.dockerNetwork);
	}

instead of using localDeployerProperties.getDocker().getNetwork() analogous to the other properties like volume mountings.

This problem was also already reported in the old local deployer repository: spring-cloud/spring-cloud-deployer-local#199 (comment)