Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong autoconfig dependency in TraceAsyncCustomAutoConfiguration #2230

Closed
bleipold opened this issue Nov 16, 2022 · 4 comments
Closed

Wrong autoconfig dependency in TraceAsyncCustomAutoConfiguration #2230

bleipold opened this issue Nov 16, 2022 · 4 comments
Labels
Milestone

Comments

@bleipold
Copy link

There seems to be a misconfiguration of autoconfiguration in the class org.springframework.cloud.sleuth.autoconfig.instrument.async.TraceAsyncCustomAutoConfiguration.

@AutoConfigureAfter( name = {"org.springframework.cloud.sleuth.instrument.scheduling.TraceSchedulingAutoConfiguration"}, value = {BraveAutoConfiguration.class} )

I think it has to be org.springframework.cloud.sleuth.autoconfig.instrument.scheduling.TraceSchedulingAutoConfiguration rather than org.springframework.cloud.sleuth.instrument.scheduling.TraceSchedulingAutoConfiguration.

@marcingrzejszczak
Copy link
Contributor

Is there any error / exception that you're seeing? Which version of Sleuth are you referring to?

@bleipold
Copy link
Author

No, there is no exception in the log. I just hit a breakpoint for IllegalStateException (in AutoConfigurationClass.getAnnotationMetadata line 237) while investigating another issue. So it may affect autoconfiguration sorting.

I use Sleuth in version 3.1.5.

@marcingrzejszczak
Copy link
Contributor

So you're saying that there's no such class? If that's the case are you willing to file a PR to fix this?

@bleipold
Copy link
Author

There is such a class but in another package (see the initial post). But I don't know, whether it's wanted or just a typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants