Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Auth method support #727

Open
jgoldverg opened this issue Jun 4, 2024 · 1 comment
Open

Github Auth method support #727

jgoldverg opened this issue Jun 4, 2024 · 1 comment

Comments

@jgoldverg
Copy link

Is your feature request related to a problem? Please describe.
Currently Vault supports Github Personal AccessTokens as an Auth method is there any plans to include this auth method into spring cloud vault and spring cloud vault config?

For a trivial solution I would expect I would expect that the property spring.cloud.vault.authentication would allow the field GITHUB where the spring.cloud.vault.token would contain the PAT. From the Vault documentation it seems like there is a separate API call for the Github Auth method which should make it fairly simple to include in a future version.

@mp911de
Copy link
Member

mp911de commented Jun 6, 2024

There's already a PR at spring-projects/spring-vault#853 so we will merge that one to create pre-requisites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants