Skip to content
This repository has been archived by the owner on Jan 8, 2023. It is now read-only.

Wrong parameter order in BaseModelSerializer #7

Open
blackvvine opened this issue Nov 30, 2019 · 0 comments
Open

Wrong parameter order in BaseModelSerializer #7

blackvvine opened this issue Nov 30, 2019 · 0 comments

Comments

@blackvvine
Copy link

Hi,

In the BaseModelSerializer definition, the Keras model is passed before the model ID:

def save(self, model, model_id):

But in the ShadowModelBundle class the model ID is passed before the model object:

self.serializer.save(ShadowModelBundle.MODEL_ID_FMT % i, shadow_model)

I think the BMS abstract class definition should be corrected with the two arguments swapped in order.

Best

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant