Rename aggregateJavadocClasspath to align with Gradle conventions

[wilkinsona]

Gradle seems to have a convention where a configuration with a name that ends with Classpath is "for consumption by tasks, not for you to declare dependencies". This is the case for compileClasspath, runtimeClasspath, testCompileClasspath, and testRuntimeClasspath. To align with this apparent convention, aggregateJavadocClasspath should perhaps be differently named as it is used for declaring dependencies.

[rwinch]

What name would you suggest? I'm not a fan of the suggestion of aggregatedJavadoc as the difference is too subtle between the task name and the configuration. It is also not very clear what this is.

Gradle seems to have a convention where a configuration with a name that ends with Classpath is "for consumption by tasks, not for you to declare dependencies".

I didn't come to the same conclusion. Another observation is that the tasks that end in Classpath are used to configure a task's classpath attribute. For example, compileClasspath is used to configure the classpath attribute of the compileJava task. In the same way, aggregateJavadocClasspath is used to configure the classpath attribute of the aggregateJavadoc task. I think the difference is that Javadoc is not quite so complex, so it doesn't need a more complex hierarchy of Configurations like compiling Java code.

[wilkinsona]

What name would you suggest?

😬 I'm struggling to think of one. I wasn't a huge fan of aggregatedJavadoc when it wrote it, which probably contributed to the thought about avoiding a naming clash or near clash with the task's name. I'll give it some more thought and see if anything occurs to me.