-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The include at the end to build the executable JAR is missing the production profile #114
Comments
Hi @DominiqueComte. I went through the guide and I see the same thing. Using You mention the AsciiDoc include files. Going forward I think we should favor correct information rather than standardized information if we have to choose one. That said, I think there is room for both using a new standard file. This is a pattern that I've implemented in a few guides, for example RabbitMQ. For this guide specifically, I think that we should update the sections to roughly track:
|
Could the instructions remain standard by merging the |
We should use includes only when they 100% match the need of the guide. I am leaving this issue open in case you want to address it be merging the |
I tried moving the contents of the "production" profile to the default build to avoid changing the build instructions, it works fine. |
At the end of the tutorial, in the "Build an executable JAR" paragraph, the build instructions are missing the "production" profile that actually builds the frontend files to include in the JAR.
Without this, running the jar and trying to access the application produces an error page and this in the console:
includes in AsciiDoc do not seem to support a parameter that could contain the missing "-Pproduction" (for Maven), though.
The text was updated successfully, but these errors were encountered: