Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPMS #700

Closed
xenoterracide opened this issue May 9, 2024 · 4 comments
Closed

JPMS #700

xenoterracide opened this issue May 9, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@xenoterracide
Copy link

please add jpms support, at least automatic modules for now. However, this issue or another issue should be added for full module-info at sometime in the future. Referencing this upstream spring issue (specifically comment) which shows all of the dependencies that could be included via the code generator spring-projects/spring-framework#18079 (comment)

@markpollack
Copy link
Member

markpollack commented Jul 22, 2024

Is this something that you could contribute @xenoterracide

@markpollack markpollack added this to the 1.0.0-RC1 milestone Jul 22, 2024
@xenoterracide
Copy link
Author

xenoterracide commented Aug 1, 2024

Unfortunately no, I don't currently have a use case for spring-ai. I simply took the list of spring projects that had not implemented an automatic-module and notified.

@csterwa csterwa added the enhancement New feature or request label Sep 4, 2024
@csterwa csterwa modified the milestones: 1.0.0-RC1, 1.0.0-M3 Sep 10, 2024
@csterwa csterwa added the help wanted Extra attention is needed label Sep 10, 2024
@markpollack markpollack modified the milestones: 1.0.0-M3, 1.0.0-M4 Oct 6, 2024
@tzolov tzolov modified the milestones: 1.0.0-M4, 1.0.0-M5 Nov 19, 2024
@markpollack markpollack modified the milestones: 1.0.0-M5, backlog Nov 22, 2024
@markpollack
Copy link
Member

I think we will wait on this, in particular to see how SF/SB boot move towards this new module system.

@xenoterracide
Copy link
Author

xenoterracide commented Feb 19, 2025

Spring Boot and Spring and literally every other spring module have an automatic module in their manifest. Spring AI and spring cloud were the only areas that didn't. I believe spring cloud has fixed theirs. So what are you waiting for exactly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants