Throwing exceptions inside a ChunkListener results in endless loop [BATCH-1783]

[spring-projects-issues]

Morten Andersen-Gott opened BATCH-1783 and commented

If an exception is thrown in beforeChunk in a ChunkListener and the job is configured with skips (but not to skip the exception that is thrown from the ChunkListener) it will result in an endless loop. Same will happen if you have configured your job for retries.

If neither retry nor skip is configured, the job will end with ExitStatus.FAILED, as expected. Which makes me suspect the issue is in the exception handling in some of the components added when skip or retry comes into play.

I've attached two files based on the Spring Batch template from STS that can be dropped in to reproduce the issue.

---

Affects: 2.1.8

Attachments:

• ExceptionThrowingChunkListener.java (355 bytes)
• module-context.xml (1.20 kB)

Referenced from: commits b075851, af84be4

[spring-projects-issues]

Morten Andersen-Gott commented

I've added a failing unit test in magott@0bf5f23
It is added to the FaultTolerantStepFactoryBeanRollbackTests which is probably not the best place to have the test. However, I did try to add it to the TaskletStepExceptionTests at first, but I couldn't get it to fail. I rely on some of the magic being applied in the FaultTolerantStepFactoryBean to reproduce the issue.

[spring-projects-issues]

Morten Andersen-Gott commented

Created a fix that will force step termination if an exception is thrown in the chunklistener. Pull request: #11

[spring-projects-issues]

Dave Syer commented

Merged pull request.