Skip to content

Commit 2e0a915

Browse files
jkschneiderphilwebb
authored andcommitted
Upgrade to micrometer 1.0.0-rc.5
See gh-11071
1 parent 24f6818 commit 2e0a915

File tree

5 files changed

+24
-2
lines changed

5 files changed

+24
-2
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/MeterBindersConfiguration.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2626
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
27+
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
2728
import org.springframework.context.annotation.Bean;
2829
import org.springframework.context.annotation.Configuration;
2930

@@ -36,25 +37,29 @@
3637
class MeterBindersConfiguration {
3738

3839
@Bean
40+
@ConditionalOnProperty(value = "spring.metrics.binders.jvmmemory.enabled", havingValue = "true", matchIfMissing = true)
3941
@ConditionalOnMissingBean(JvmMemoryMetrics.class)
4042
public JvmMemoryMetrics jvmMemoryMetrics() {
4143
return new JvmMemoryMetrics();
4244
}
4345

4446
@Bean
4547
@ConditionalOnMissingBean(LogbackMetrics.class)
48+
@ConditionalOnProperty(value = "spring.metrics.binders.logback.enabled", havingValue = "true", matchIfMissing = true)
4649
@ConditionalOnClass(name = "ch.qos.logback.classic.Logger")
4750
public LogbackMetrics logbackMetrics() {
4851
return new LogbackMetrics();
4952
}
5053

5154
@Bean
55+
@ConditionalOnProperty(value = "spring.metrics.binders.uptime.enabled", havingValue = "true", matchIfMissing = true)
5256
@ConditionalOnMissingBean(UptimeMetrics.class)
5357
public UptimeMetrics uptimeMetrics() {
5458
return new UptimeMetrics();
5559
}
5660

5761
@Bean
62+
@ConditionalOnProperty(value = "spring.metrics.binders.processor.enabled", havingValue = "true", matchIfMissing = true)
5863
@ConditionalOnMissingBean(ProcessorMetrics.class)
5964
public ProcessorMetrics processorMetrics() {
6065
return new ProcessorMetrics();

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/simple/SimpleProperties.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import java.time.Duration;
2020

21+
import io.micrometer.core.instrument.simple.CountingMode;
2122
import io.micrometer.core.instrument.simple.SimpleMeterRegistry;
2223

2324
import org.springframework.boot.context.properties.ConfigurationProperties;
@@ -42,6 +43,8 @@ public class SimpleProperties {
4243
*/
4344
private Duration step = Duration.ofSeconds(10);
4445

46+
private CountingMode mode = CountingMode.Cumulative;
47+
4548
public boolean getEnabled() {
4649
return this.enabled;
4750
}
@@ -57,4 +60,12 @@ public Duration getStep() {
5760
public void setStep(Duration step) {
5861
this.step = step;
5962
}
63+
64+
public CountingMode getMode() {
65+
return mode;
66+
}
67+
68+
public void setMode(CountingMode mode) {
69+
this.mode = mode;
70+
}
6071
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/simple/SimplePropertiesConfigAdapter.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import java.time.Duration;
2020

21+
import io.micrometer.core.instrument.simple.CountingMode;
2122
import io.micrometer.core.instrument.simple.SimpleConfig;
2223

2324
import org.springframework.boot.actuate.autoconfigure.metrics.export.PropertiesConfigAdapter;
@@ -49,4 +50,9 @@ public boolean enabled() {
4950
public Duration step() {
5051
return get(SimpleProperties::getStep, SimpleConfig.super::step);
5152
}
53+
54+
@Override
55+
public CountingMode mode() {
56+
return get(SimpleProperties::getMode, SimpleConfig.super::mode);
57+
}
5258
}

spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/metrics/web/servlet/WebMvcMetricsFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ private HandlerExecutionChain getHandlerExecutionChain(HttpServletRequest reques
8989

9090
private void filterWithMetrics(HttpServletRequest request,
9191
HttpServletResponse response, FilterChain filterChain, Object handler)
92-
throws IOException, ServletException, NestedServletException {
92+
throws IOException, ServletException {
9393
this.webMvcMetrics.preHandle(request, handler);
9494
try {
9595
filterChain.doFilter(request, response);

spring-boot-project/spring-boot-dependencies/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@
112112
<logback.version>1.2.3</logback.version>
113113
<lombok.version>1.16.18</lombok.version>
114114
<mariadb.version>2.2.0</mariadb.version>
115-
<micrometer.version>1.0.0-rc.3</micrometer.version>
115+
<micrometer.version>1.0.0-rc.5</micrometer.version>
116116
<mssql-jdbc.version>6.2.2.jre8</mssql-jdbc.version>
117117
<mockito.version>2.12.0</mockito.version>
118118
<mongo-driver-reactivestreams.version>1.6.0</mongo-driver-reactivestreams.version>

0 commit comments

Comments
 (0)