Skip to content

Commit 7979a51

Browse files
committed
Fix Maven Plugin tests on main
See gh-47318 See gh-47319
1 parent 27715de commit 7979a51

File tree

8 files changed

+4
-7
lines changed

8 files changed

+4
-7
lines changed

build-plugin/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven/JarIntegrationTests.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,6 @@ void whenAnEntryIsOptionalByDefaultDoesNotAppearInTheRepackagedJar(MavenBuild ma
187187
assertThat(jar(repackaged)).hasEntryWithNameStartingWith("BOOT-INF/classes/")
188188
.hasEntryWithNameStartingWith("BOOT-INF/lib/spring-context")
189189
.hasEntryWithNameStartingWith("BOOT-INF/lib/spring-core")
190-
.hasEntryWithNameStartingWith("BOOT-INF/lib/spring-jcl")
191190
.doesNotHaveEntryWithNameStartingWith("BOOT-INF/lib/log4j-api-");
192191
});
193192
}
@@ -199,7 +198,6 @@ void whenAnEntryIsOptionalAndOptionalsIncludedAppearsInTheRepackagedJar(MavenBui
199198
assertThat(jar(repackaged)).hasEntryWithNameStartingWith("BOOT-INF/classes/")
200199
.hasEntryWithNameStartingWith("BOOT-INF/lib/spring-context")
201200
.hasEntryWithNameStartingWith("BOOT-INF/lib/spring-core")
202-
.hasEntryWithNameStartingWith("BOOT-INF/lib/spring-jcl")
203201
.hasEntryWithNameStartingWith("BOOT-INF/lib/log4j-api-");
204202
});
205203
}
@@ -211,7 +209,6 @@ void whenAnEntryIsOptionalAndOptionalsExcludedDoesNotAppearInTheRepackagedJar(Ma
211209
assertThat(jar(repackaged)).hasEntryWithNameStartingWith("BOOT-INF/classes/")
212210
.hasEntryWithNameStartingWith("BOOT-INF/lib/spring-context")
213211
.hasEntryWithNameStartingWith("BOOT-INF/lib/spring-core")
214-
.hasEntryWithNameStartingWith("BOOT-INF/lib/spring-jcl")
215212
.doesNotHaveEntryWithNameStartingWith("BOOT-INF/lib/log4j-api-");
216213
});
217214
}
File renamed without changes.
File renamed without changes.
File renamed without changes.

build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/AbstractPackagerMojo.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,15 +117,15 @@ public abstract class AbstractPackagerMojo extends AbstractDependencyFilterMojo
117117
* Include optional dependencies.
118118
* @since 3.5.7
119119
*/
120-
@Parameter(defaultValue = "true")
121-
public boolean includeOptional = true;
120+
@Parameter(defaultValue = "false")
121+
public boolean includeOptional;
122122

123123
/**
124124
* Include JAR tools.
125125
* @since 3.3.0
126126
*/
127-
@Parameter(defaultValue = "false")
128-
public boolean includeTools;
127+
@Parameter(defaultValue = "true")
128+
public boolean includeTools = true;
129129

130130
/**
131131
* Layer configuration with options to disable layer creation, exclude layer tools

0 commit comments

Comments
 (0)