Skip to content

Commit dccb842

Browse files
committed
Polish "Apply dependsOn semantic between Liquibase and JPA"
See gh-18673
1 parent bacd36f commit dccb842

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/liquibase/LiquibaseAutoConfiguration.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@
7171
@ConditionalOnProperty(prefix = "spring.liquibase", name = "enabled", matchIfMissing = true)
7272
@Conditional(LiquibaseDataSourceCondition.class)
7373
@AutoConfigureAfter({ DataSourceAutoConfiguration.class, HibernateJpaAutoConfiguration.class })
74-
@Import({ LiquibaseJdbcOperationsDependsOnPostProcessor.class,
75-
LiquibaseNamedParameterJdbcOperationsDependsOnPostProcessor.class,
76-
LiquibaseEntityManagerFactoryDependsOnPostProcessor.class })
74+
@Import({ LiquibaseEntityManagerFactoryDependsOnPostProcessor.class,
75+
LiquibaseJdbcOperationsDependsOnPostProcessor.class,
76+
LiquibaseNamedParameterJdbcOperationsDependsOnPostProcessor.class })
7777
public class LiquibaseAutoConfiguration {
7878

7979
@Bean

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/liquibase/LiquibaseAutoConfigurationTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -324,21 +324,21 @@ void userConfigurationBeans() {
324324
}
325325

326326
@Test
327-
void userConfigurationJdbcTemplateDependency() {
328-
this.contextRunner.withConfiguration(AutoConfigurations.of(JdbcTemplateAutoConfiguration.class))
327+
void userConfigurationEntityManagerFactoryDependency() {
328+
this.contextRunner.withConfiguration(AutoConfigurations.of(HibernateJpaAutoConfiguration.class))
329329
.withUserConfiguration(LiquibaseUserConfiguration.class, EmbeddedDataSourceConfiguration.class)
330330
.run((context) -> {
331-
BeanDefinition beanDefinition = context.getBeanFactory().getBeanDefinition("jdbcTemplate");
331+
BeanDefinition beanDefinition = context.getBeanFactory().getBeanDefinition("entityManagerFactory");
332332
assertThat(beanDefinition.getDependsOn()).containsExactly("springLiquibase");
333333
});
334334
}
335335

336336
@Test
337-
void userConfigurationEntityManagerFactoryDependency() {
338-
this.contextRunner.withConfiguration(AutoConfigurations.of(HibernateJpaAutoConfiguration.class))
337+
void userConfigurationJdbcTemplateDependency() {
338+
this.contextRunner.withConfiguration(AutoConfigurations.of(JdbcTemplateAutoConfiguration.class))
339339
.withUserConfiguration(LiquibaseUserConfiguration.class, EmbeddedDataSourceConfiguration.class)
340340
.run((context) -> {
341-
BeanDefinition beanDefinition = context.getBeanFactory().getBeanDefinition("entityManagerFactory");
341+
BeanDefinition beanDefinition = context.getBeanFactory().getBeanDefinition("jdbcTemplate");
342342
assertThat(beanDefinition.getDependsOn()).containsExactly("springLiquibase");
343343
});
344344
}

0 commit comments

Comments
 (0)