Skip to content

Ease extension of DataSourcePublicMetrics #10288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mduesterhoeft opened this issue Sep 14, 2017 · 2 comments
Closed

Ease extension of DataSourcePublicMetrics #10288

mduesterhoeft opened this issue Sep 14, 2017 · 2 comments
Labels
status: duplicate A duplicate of another issue

Comments

@mduesterhoeft
Copy link

I want to publish additional DataSource metrics that a Tomcat DataSource provides (number of idle connections, current pool size).

Currently, this is very hard to do because the functionality in DataSourcePublicMetrics cannot be reused by subclasses.

I will come up with a proposal on how to improve this situation.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 14, 2017
@wilkinsona
Copy link
Member

Thanks for raising this. If you intend to immediately make a proposal in a pull request, there's no need to open an issue too. I'll close this one as a duplicate of the PR.

@wilkinsona
Copy link
Member

Duplicate of #10289

@wilkinsona wilkinsona marked this as a duplicate of #10289 Sep 14, 2017
@wilkinsona wilkinsona added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wilkinsona @mduesterhoeft @spring-projects-issues