Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename spring.mvc.path-match.* and spring.mvc.content-negotiation.* properties #11913

Closed
wilkinsona opened this issue Feb 5, 2018 · 1 comment
Assignees
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Feb 5, 2018

#11105 added some new properties that are grouped beneath spring.mvc.path-match and spring.mvc.content-negotation. We should rename them so that there's no need for the - characters.

spring.mvc.pathmatch and spring.mvc.contentnegotation are the easy (and most obvious) options, but perhaps there's something better?

@wilkinsona wilkinsona added type: task A general task for: team-attention An issue we'd like other members of the team to review priority: high labels Feb 5, 2018
@wilkinsona wilkinsona added this to the 2.0.0.RC2 milestone Feb 5, 2018
@spring-projects spring-projects deleted a comment from pkostrzewa Feb 6, 2018
@spring-projects spring-projects deleted a comment from spencergibb Feb 6, 2018
@spring-projects spring-projects deleted a comment from pkostrzewa Feb 6, 2018
@spring-projects spring-projects deleted a comment from spencergibb Feb 6, 2018
@bclozel
Copy link
Member

bclozel commented Feb 7, 2018

👍 This is indeed an oversight on my part.
I can't find better alternatives, and those names refer to Spring MVC configuration types so in my opinion we'd better keep it that way.

@snicoll snicoll removed the for: team-attention An issue we'd like other members of the team to review label Feb 7, 2018
@wilkinsona wilkinsona self-assigned this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

3 participants