Skip to content

Make Actuator endpoint metrics distinguishable #13435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shakuzen opened this issue Jun 11, 2018 · 2 comments
Open

Make Actuator endpoint metrics distinguishable #13435

shakuzen opened this issue Jun 11, 2018 · 2 comments
Labels
status: blocked An issue that's blocked on an external project change type: enhancement A general enhancement
Milestone

Comments

@shakuzen
Copy link
Member

When querying metrics, I would like to be able to query metrics related to endpoints (http.server.requests) such that I can filter out non-user facing endpoints like the Actuator endpoints. When monitoring, I want to look at things like request rate, error rate, and latency on user-facing endpoints, without access to the Actuator endpoints affecting those metrics.

If such filtering were possible, it could be used in excluding Actuator endpoints from alerts and graphs and ad hoc queries, when desired.

Some metrics backends may allow querying with wildcards/regex to approximate this. For example, in PromQL, the 5m request rate excluding Actuator endpoints might be written like this:

rate(http_server_requests_seconds_count{uri !~ "/actuator.*"}[5m])

But for a query like above to work, it would require all applications use the same management context-path. Having a simpler, more robust way to filter via a tag would be helpful.

/CC @jkschneider

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 11, 2018
@philwebb philwebb changed the title 🎁 make Actuator endpoint metrics distinguishable Make Actuator endpoint metrics distinguishable Jun 11, 2018
@wilkinsona
Copy link
Member

This feels to me like something that could build on #13064 with something that's aware of all the actuator endpoint paths contributing a tag for requests made to those paths. We should consider the performance impact of any such contribution as it will have to perform matching against every request.

@wilkinsona wilkinsona added type: enhancement A general enhancement status: waiting-for-triage An issue we've not yet triaged and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 14, 2018
@philwebb philwebb removed the status: waiting-for-triage An issue we've not yet triaged label Nov 16, 2018
@philwebb philwebb added this to the 2.x milestone Nov 16, 2018
@philwebb philwebb added the status: blocked An issue that's blocked on an external project change label Nov 16, 2018
@philwebb philwebb modified the milestones: 2.x, 3.x Aug 19, 2022
@wilkinsona
Copy link
Member

spring-projects/spring-framework#29210 may help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked An issue that's blocked on an external project change type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants