Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServletWebServerFactoryConfiguration is package private with public inner classes #19395

Closed
snicoll opened this issue Dec 18, 2019 · 2 comments
Closed

ServletWebServerFactoryConfiguration is package private with public inner classes #19395

snicoll opened this issue Dec 18, 2019 · 2 comments
Assignees
@snicoll
Labels
type: task A general task
Milestone
2.1.12

Comments

@snicoll
Copy link
Member

snicoll commented Dec 18, 2019

while browsing the code I noticed this inconsistency:

spring-boot/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/servlet/ServletWebServerFactoryConfiguration.java

Line 68 in ad6859f

public static class EmbeddedTomcat {

We may want to add a rule for it in javaformat as well.
@snicoll snicoll added type: task A general task status: waiting-for-triage An issue we've not yet triaged for: team-attention An issue we'd like other members of the team to review labels Dec 18, 2019
@wilkinsona wilkinsona changed the title EmbedTomcat is a public inner class while it's outer class is package private EmbeddedTomcat is a public inner class while it's outer class is package private Dec 18, 2019
@wilkinsona
Copy link
Member

EmbeddedJetty and EmbeddedUndertow have the same inconsistency.

@philwebb philwebb mentioned this issue Dec 18, 2019
Open
@philwebb
Copy link
Member

We should make them package private as well

@philwebb philwebb removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Dec 18, 2019
@philwebb philwebb added this to the 2.1.x milestone Dec 18, 2019
@wilkinsona wilkinsona changed the title EmbeddedTomcat is a public inner class while it's outer class is package private EmbeddedTomcat is a public inner class while its outer class is package private Dec 20, 2019
@snicoll snicoll self-assigned this Dec 21, 2019
@snicoll snicoll changed the title EmbeddedTomcat is a public inner class while its outer class is package private ServletWebServerFactoryConfiguration is package private with public inner classes Dec 23, 2019
@snicoll snicoll mentioned this issue Dec 23, 2019
Closed
@snicoll snicoll modified the milestones: 2.1.x, 2.1.12 Dec 23, 2019
@snicoll snicoll mentioned this issue Dec 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
2.1.12
Development

No branches or pull requests
3 participants
@snicoll @philwebb @wilkinsona