Skip to content

Extract EnvironmentPostProcessor logic from ConfigFileApplicationListener #21299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue May 3, 2020 · 5 comments
Closed

Extract EnvironmentPostProcessor logic from ConfigFileApplicationListener #21299

philwebb opened this issue May 3, 2020 · 5 comments
Labels
status: superseded An issue that has been superseded by another theme: config-data Issues related to the configuration theme type: enhancement A general enhancement

Comments

@philwebb
Copy link
Member

philwebb commented May 3, 2020

It's bit odd that ConfigFileApplicationListener is currently the thing that invoked EnvironmentPostProcessors. I feel like the logic should live in the org.springframework.boot.env package.
@philwebb philwebb added the type: enhancement A general enhancement label May 3, 2020
@philwebb philwebb added this to the 2.x milestone May 3, 2020
@philwebb philwebb added the theme: config-data Issues related to the configuration theme label Jun 5, 2020
@onobc
Copy link
Contributor

onobc commented Jun 22, 2020

Hi @philwebb - I too have thought this about CFAL for a while now. I would love to take this one unless you are already planning on moving out on it?

@onobc
Copy link
Contributor

onobc commented Jun 22, 2020

Also, what are your thoughts about inlining the invocation of the EPPs in SpringApplication like what is done for the ACIs currently?

@wilkinsona wilkinsona added the status: pending-design-work Needs design work before any code can be developed label Jun 22, 2020
@wilkinsona
Copy link
Member

Thanks for the offer, @Bono007. We're in the early stages of designing a revamp of configuration property file loading and profile support for Spring Boot 2.4. We won't be able to tackle this issue until that work has been completed.

@onobc
Copy link
Contributor

onobc commented Jun 22, 2020

I look forward to seeing the revamp. Thanks for the info @wilkinsona .

@wilkinsona
Copy link
Member

This has been tackled in #22497.

@wilkinsona wilkinsona removed this from the 2.x milestone Jul 24, 2020
@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another and removed status: pending-design-work Needs design work before any code can be developed labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another theme: config-data Issues related to the configuration theme type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philwebb @wilkinsona @onobc