Skip to content

Relax ConfigFileApplicationListener.onApplicationEvent() to log a warning rather than throw an exception #22734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spencergibb opened this issue Aug 4, 2020 · 2 comments
Closed

Relax ConfigFileApplicationListener.onApplicationEvent() to log a warning rather than throw an exception #22734

spencergibb opened this issue Aug 4, 2020 · 2 comments
Labels
status: invalid An issue that we don't feel is valid

Comments

@spencergibb
Copy link
Member

Spring Cloud is deprecating its usage of ConfigFileApplicationListener, but it still needs to work.

/cc @philwebb
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 4, 2020
@spencergibb
Copy link
Member Author

Related #22601

@spencergibb
Copy link
Member Author

Since the usage wasn't via spring.factories, a subclass that overrides the onApplicationEvent() to not throw an exception works.

@bclozel bclozel added status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bclozel @spencergibb @spring-projects-issues