-
Notifications
You must be signed in to change notification settings - Fork 41.1k
Improve ways in which configuration property metadata default values can be provided #28039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I too could have used this protection here. |
I was sad when I dug in and discovered that the config annotation processor was not an actual magic lamp that created magic metadata for me but instead was just some code written by humans that can handle only a limited set of default value types. ;) But all kidding aside, I am interested in working this one @wilkinsona if its up for grabs. I have not yet done anything in the way of the annotation processors yet (other than figure out how to step through debugger during compile step.
I dug deeper and the above options/questions sort of fell out as I learned more about how the processor works and where it logs warnings currently. I will tidy up what I have tomorrow and submit. |
Having seen #28062, we're not sure that this is a good idea. We'd like the explore some alternative approaches such as:
|
The hope is that we could avoid problems like #28037. In that case there's a
List<String>
property with a default value created withnew ArrayList<>("…")
. The annotation processor can't extract the default value so we rely on an entry in the manual metadata for it. For such a property that doesn't have an entry in the manual metadata, it'd be good if the annotation processor could fail or generate a warning.The text was updated successfully, but these errors were encountered: