Skip to content

Move auto-configuration for reactive Elasticsearch client into o.s.b.autoconfigure.elasticsearch #28068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Sep 20, 2021 · 5 comments
Closed

Move auto-configuration for reactive Elasticsearch client into o.s.b.autoconfigure.elasticsearch #28068

wilkinsona opened this issue Sep 20, 2021 · 5 comments
Assignees
@wilkinsona
Labels
type: enhancement A general enhancement
Milestone
3.0.0-M4

Comments

@wilkinsona
Copy link
Member

No description provided.

@wilkinsona wilkinsona added the type: enhancement A general enhancement label Sep 20, 2021
@wilkinsona wilkinsona added this to the 2.6.x milestone Sep 20, 2021
@wilkinsona wilkinsona self-assigned this Sep 20, 2021
@wilkinsona
Copy link
Member Author

wilkinsona commented Sep 21, 2021 •
edited
Loading

Having implemented it, I'm not completely convinced that this is a good idea. The thing that putting me off the most is the impact that it has on other auto-configuration classes and any @AutoConfigureBefore and @AutoConfigureAfter annotations that references the auto-configuration class that's moving. That's fine within our own codebase, but a pain for third parties, particularly if they want to try and support Boot 2.6 alongside an earlier version. I'm not sure that the benefit of moving things (which is largely cosmetic) outweighs this cost.

@wilkinsona wilkinsona added the for: team-meeting An issue we'd like to discuss as a team to make progress label Sep 21, 2021
@philwebb
Copy link
Member

I wonder if we should look again at #14860. Seems like I already did a fair bit of work on it (of which I have no memory).

@philwebb philwebb added status: on-hold We can't start working on this issue yet and removed for: team-meeting An issue we'd like to discuss as a team to make progress labels Sep 22, 2021
@philwebb
Copy link
Member

We'll take a look at #14860, but if we can't get that in then we'll leave things as they are.

@philwebb philwebb modified the milestones: 2.6.x, 2.x Oct 13, 2021
@wilkinsona
Copy link
Member Author

Flagging for team attention so that we can consider doing this in 3.0 without #14860.

@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Apr 26, 2022
@wilkinsona wilkinsona modified the milestones: 2.x, 3.0.x Apr 27, 2022
@wilkinsona wilkinsona removed status: on-hold We can't start working on this issue yet for: team-attention An issue we'd like other members of the team to review labels Apr 27, 2022
@wilkinsona wilkinsona modified the milestones: 3.0.x, 3.0.0-M4 Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.0-M4
Development

No branches or pull requests
3 participants
@philwebb @wilkinsona and others