-
Notifications
You must be signed in to change notification settings - Fork 40.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with the migration from Sleuth to Micrometer #33977
Comments
@benediktwetzel Could you share which metrics are published for |
Thanks for your answer! I took another look at our code and found that we are creating a new span for some method calls (via AOP and annotations, so didn't see it before). Span newSpan = this.tracer.nextSpan().name(methodName);
this.tracer.withSpanInScope(newSpan.start()); Hower, shouldn't this also be affected by the |
This code snippet is directly calling the tracing API and is not affected by the Observation support. If you want to leverage this support, you can rewrite this using the
I'm closing this issue since the current behavior is expected from a Spring Boot point of view. Thanks for reporting this! |
@bclozel Thank you a lot! Can you also help me by the migration from the Sleuth configuration to Micrometer? |
@benediktwetzel You'll get better support with the Micrometer docs and Community (there's a dedicated Slack instance, see the https://micrometer.io/ homepage). |
@benediktwetzel If you haven't seen it already, you may also be interested in the migration guide that the Micrometer team have produced. |
Hello,
we are upgrading from SB2.7 to SB3 and the migration from Sleuth to Micrometer is causing problems.
We register an
ObservationPredicate
Bean to ignore some observerations. For testing, we returnfalse
in all cases:However, to our surprise, some traces are still displayed in Zipkin. These are metrics from methods with are annotated with
@Scheduled(fixedRateString = X)
. Why are these Observations still being considered?Also, we have some Sleuth configurations in our SB2.7 application, and we can't find any documentation to migrate the old configuration to Micrometer.
In particular, the following configuration parameters are the problem:
Is there any guidance on how we can migrate this configuration to Micrometer?
Thanks in advance! :)
The text was updated successfully, but these errors were encountered: