Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide service connection support for Hazelcast #34778

Closed
wilkinsona opened this issue Mar 27, 2023 · 2 comments
Closed

Provide service connection support for Hazelcast #34778

wilkinsona opened this issue Mar 27, 2023 · 2 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@wilkinsona
Copy link
Member

Suggested by @eddumelendez in #34760, it would be interesting to have service connection support for Hazelcast. Unlike other services, our auto-configuration for Hazelcast leans very heavily on separate configuration files. Specifically, there's no property that's used to provide the address of a Hazelcast instance, instead this is determined from the Hazelcast configuration file. Given this arrangement, there isn't such an obvious mapping of existing properties into connection details.
@wilkinsona wilkinsona added type: enhancement A general enhancement status: pending-design-work Needs design work before any code can be developed labels Mar 27, 2023
@wilkinsona wilkinsona added this to the 3.x milestone Mar 27, 2023
@wilkinsona wilkinsona added the for: team-meeting An issue we'd like to discuss as a team to make progress label Mar 27, 2023
@wilkinsona wilkinsona mentioned this issue Mar 27, 2023
Closed
@wilkinsona
Copy link
Member Author

We might be able to add HazelcastConnectionDetails that exposes a ClientConfig. With some changes to the auto-configuration we could then use the ClientConfig from HazelcastConnectionDetails in favor of any user-provided ClientConfig bean.

@wilkinsona wilkinsona removed status: pending-design-work Needs design work before any code can be developed for: team-meeting An issue we'd like to discuss as a team to make progress labels Jun 21, 2023
@nosan nosan mentioned this issue Sep 22, 2024
Closed
@philwebb
Copy link
Member

Closing in favor of PR #42416. Thanks @nosan!

@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed type: enhancement A general enhancement labels Sep 23, 2024
@philwebb philwebb removed this from the 3.x milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona