Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HttpClient based Zipkin sender #39545

Closed
mhalbritter opened this issue Feb 14, 2024 · 5 comments
Closed

Implement HttpClient based Zipkin sender #39545

mhalbritter opened this issue Feb 14, 2024 · 5 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@mhalbritter
Copy link
Contributor

Currently, we have 3 Zipkin senders:

  • URLConnectionSender, needs zipkin-sender-urlconnection
  • RestTemplate based one, needs spring-web
  • WebClient based one, needs spring-webflux

With the changes in #39049, the webclient one will likely be removed, as the Zipkin sender interface is no longer async by default and we have to call block.

We should implement a JDK HttpClient based sender, which can be used without any dependencies.

@mhalbritter mhalbritter added the type: enhancement A general enhancement label Feb 14, 2024
@mhalbritter mhalbritter added this to the 3.x milestone Feb 14, 2024
@mhalbritter
Copy link
Contributor Author

@wilkinsona
Copy link
Member

wilkinsona commented Feb 14, 2024

I wonder if we should only provide an HttpClient-based sender. It would simplify things a little and give us less code to maintain if we got rid of the other two as well as the WebClient-based one.

@mhalbritter
Copy link
Contributor Author

Yeah, I think that's a good idea. I'll try to get the HttpClient sender into 3.3.x and then we can deprecate the other ones.

@mhalbritter mhalbritter modified the milestones: 3.x, 3.3.x Feb 14, 2024
@mhalbritter mhalbritter self-assigned this Feb 20, 2024
@mhalbritter mhalbritter added the status: blocked An issue that's blocked on an external project change label Feb 20, 2024
@mhalbritter
Copy link
Contributor Author

Blocked until #39049 is merged.

@mhalbritter mhalbritter removed the status: blocked An issue that's blocked on an external project change label Feb 20, 2024
@mhalbritter mhalbritter modified the milestones: 3.3.x, 3.3.0-M2 Feb 20, 2024
@codefromthecrypt
Copy link
Contributor

this is great. looking forward to the removal of the other senders!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants