Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird metrics behaviour when Request Method:OPTIONS #4198

Closed
celiovasconcelos opened this issue Oct 15, 2015 · 1 comment
Closed

Weird metrics behaviour when Request Method:OPTIONS #4198

celiovasconcelos opened this issue Oct 15, 2015 · 1 comment

Comments

@celiovasconcelos
Copy link 

@RequestMapping(value = "/search/{id}", method = { RequestMethod.GET })

When calling OPTIONS htttp://localhost:8080/search/142
This register two metrics with the @PathVariable value

somepackage.status.200.search.143.count
somepackage.gauge.response.search.143.value

I think that OPTIONS should have a special treatment.
Also, it would be nice to have a property to disable OPTION metrics in application.properties
@philwebb philwebb added the type: enhancement A general enhancement label Oct 19, 2015
@wilkinsona
Copy link
Member

This has been superseded by the planned move to Micrometer-based metrics (#9970)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philwebb @celiovasconcelos @wilkinsona