Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review servlet web server factories being ResourceLoaderAware #44315

Open
wilkinsona opened this issue Feb 18, 2025 · 0 comments
Open

Review servlet web server factories being ResourceLoaderAware #44315

wilkinsona opened this issue Feb 18, 2025 · 0 comments
Labels
status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: task A general task
Milestone
4.0.x

Comments

@wilkinsona
Copy link
Member

The servlet web server factories have been ResourceLoaderAware since they were introduced:

Each factory uses the ResourceLoader, if set, to obtain the class loader that it uses. We should review this, with a couple of questions in mind:

  • Should the ClassLoader be provided in a way that doesn't add setResourceLoader to the factories' public API?
  • Should the reactive factories be updated to use the same class loading arrangement?
@wilkinsona wilkinsona added status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: task A general task labels Feb 18, 2025
@wilkinsona wilkinsona added this to the 4.0.x milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: task A general task
Projects
None yet
Milestone
4.0.x
Development

No branches or pull requests
1 participant
@wilkinsona