Skip to content

Actuator: Add KV property to Metric #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmkgreen opened this issue Apr 15, 2016 · 2 comments
Closed

Actuator: Add KV property to Metric #5701

jmkgreen opened this issue Apr 15, 2016 · 2 comments
Labels
status: duplicate A duplicate of another issue

Comments

@jmkgreen
Copy link

InfluxDB allow metric submission with what they call "fields" which are merely a bunch of key=value pairs.

Would it make sense to support this as an optional property (Map<String, String>) on Metric or some derived class? I'm struggling to think it makes sense on a derived class myself.

Clearly writers can then support the sending of these as they see fit.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 15, 2016
@dsyer
Copy link
Member

dsyer commented Apr 16, 2016

The "standard" way to do this up to now is to decompose the metric names into field values. Some metrics lend themselves to that more than others, it has to be said, but if you control the namespace of your own metrics, you always have that option. Also, many of the use cases for those tags are to represent metadata about the sender (app, instance, cluster id etc.) so those are basically static and can always be added on top of the Boot metrics without parsing or changing the metric name. Some of the existing exporters already do that (e.g. the Redis one or the Atlas one in Spring Cloud Netflix).

It's pretty common practice amongst users of graphite for instance, and the metric metadata in Spring Boot was chosen intentionally as a "lowest common denominator" in the same spirit. Having said that, Spring Boot 2.0 gives us an opportunity to add "dimensional" metrics, and we have discussed moving metrics out to their own project as part of that effort.

@dsyer dsyer added question and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 16, 2016
@philwebb philwebb added for: stackoverflow A question that's better suited to stackoverflow.com and removed question labels Aug 30, 2016
@philwebb
Copy link
Member

Duplicates #4909

@philwebb philwebb added status: duplicate A duplicate of another issue and removed for: stackoverflow A question that's better suited to stackoverflow.com labels Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

4 participants