Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider AssertJ variant of MockMvc #5729

Closed
philwebb opened this issue Apr 19, 2016 · 14 comments
Closed

Consider AssertJ variant of MockMvc #5729

philwebb opened this issue Apr 19, 2016 · 14 comments
Labels
for: external-project For an external project and not something we can fix

Comments

@philwebb
Copy link
Member

No description provided.

@philwebb philwebb added type: enhancement A general enhancement for: team-attention An issue we'd like other members of the team to review labels Apr 19, 2016
@philwebb philwebb added this to the 1.4.0.M3 milestone Apr 19, 2016
@philwebb
Copy link
Member Author

https://github.com/philwebb/spring-boot/tree/gh-5729

@sbrannen
Copy link
Member

Related discussion on Stack Overflow:

http://stackoverflow.com/questions/34447446/is-there-a-way-to-use-assertj-assertions-with-spring-mvc-test

@philwebb philwebb removed this from the 1.4.0.M3 milestone Apr 27, 2016
@linux-china
Copy link

linux-china commented May 13, 2016

@philwebb
Copy link
Member Author

@linux-china We're still considering what to do. The worry is that an alternative MockMVC might be confusing.

@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label May 19, 2016
@jhyot
Copy link

jhyot commented Nov 17, 2016

This would be great for us, since we have completely moved from Hamcrest to AssertJ, and now MockMVC is bringing Hamcrest back through the back door.

@marceloverdijk
Copy link

+1

For a project I also want to move from hamcrest to assertj.

The project uses Kotlin which makes it also a bit nasty to use the is matchers.

@volodymyrprokopyuk
Copy link

It would be nice to be able to use AssertJ assertions with MockMVCResultMathces.

@PascalSchumacher
Copy link
Contributor

+1, AssertJ support would be great

@jcthalys
Copy link

+1, please AssertJ support...

@bclozel
Copy link
Member

bclozel commented Mar 23, 2018

I think this should move to Spring Framework; I've created SPR-16637.

I'll close this issue of the framework team moves in favor of that. Please comment/vote on that issue if you feel this should be supported: any feedback or use case that describes the importance of that feature should help.

@ashishjmeshram
Copy link

+1

@manueljordan
Copy link

+1 AssertJ is very valuable to test items of a collection through tuple and very easy to test Date objects through parse method. I am sure Spring MVC Test with AssertJ are going to improve the testing code work.

@sudhirtumati
Copy link

+1

@philwebb
Copy link
Member Author

philwebb commented Sep 7, 2018

Closing in favor of the Framework Issue.

@philwebb philwebb closed this as completed Sep 7, 2018
@philwebb philwebb added for: external-project For an external project and not something we can fix and removed type: enhancement A general enhancement labels Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project For an external project and not something we can fix
Projects
None yet
Development

No branches or pull requests