Skip to content

Decouple MetricsFilter from Spring MVC #7505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Nov 28, 2016 · 1 comment
Closed

Decouple MetricsFilter from Spring MVC #7505

wilkinsona opened this issue Nov 28, 2016 · 1 comment
Assignees
@wilkinsona
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Nov 28, 2016 •
edited by philwebb
Loading

MetricsFilter uses Spring MVC's BEST_MATCHING_PATTERN_ATTRIBUTE request attribute to determine the metric name for a request. This couples MetricsFilter to Spring MVC unnecessarily and causes problems with other web frameworks such as Jersey (see #5875).

I think it would be better if MetricsFilter defined its own request attribute and specified the format of its value. This would allow web frameworks to map from whatever format they use for url templates to something that's suitable for us in a metric name. We could provide an implementation for Spring MVC and, to fix #5875, an implementation for Jersey too.
@wilkinsona wilkinsona added type: enhancement A general enhancement for: team-attention An issue we'd like other members of the team to review labels Nov 28, 2016
@wilkinsona wilkinsona mentioned this issue Nov 28, 2016
Closed
@wilkinsona wilkinsona removed the for: team-attention An issue we'd like other members of the team to review label Nov 30, 2016
@wilkinsona wilkinsona added this to the 1.5.0 RC1 milestone Nov 30, 2016
@wilkinsona wilkinsona self-assigned this Nov 30, 2016
@wilkinsona wilkinsona mentioned this issue Dec 2, 2016
Closed
@wilkinsona wilkinsona modified the milestones: 2.0.0.M1, 1.5.0 RC1 Dec 2, 2016
@wilkinsona wilkinsona mentioned this issue Dec 15, 2016
Closed
@philwebb philwebb modified the milestones: 2.0.0.M1, 2.0.0 Jan 12, 2017
@wilkinsona
Copy link
Member Author

The planned move to Micrometer-based metrics will get rid of the metrics filter.

@wilkinsona wilkinsona removed this from the 2.0.0 milestone Aug 11, 2017
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed priority: normal type: enhancement A general enhancement labels Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona