-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Provide an official SPI for reinitialising logging #8235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like a bug in |
I couldn't reproduce this with Dalston snapshots or with Camden.SR5 (so the log file has the debug logging in it). I also couldn't find any reference to |
I reproduced it with the same versions as the OP. This line causes the different behaviour when |
edit: Sorry, had a wrong maven configuration and used a wrong version for snapshot. DALSTON.BUILD-SNAPSHOT is not working correctly |
OK, I see. You need to actually have an active |
I'm not keen to do that. Feels like giving you another bullet and encouraging you to aim at your foot. Can we take a few steps back and consider how we started down the path of Spring Cloud messing around with the logging system to begin with? I'd like to find a different, more robust solution to the problem as a whole. |
@dsyer and I discussed this a bit today. The best that we've been able to come up with is to move as much logic out of |
Any update on this? |
spring-cloud/spring-cloud-commons#608 will hopefully remove the need for this. |
If the debug-property is set to true and a logging.path is set, then the output does not print a autoconfiguration-report, if spring-cloud-starter-config is present.
I used the following components to simulate the problem.
(/home/test/empty-git-repo is an empty git repo)
Then stdout and the ./logs/spring.log file contain the following:
So there is no report printed.
If I remove the settings of logging.path from the application.yml in the demo-app, the output is printed correctly:
The text was updated successfully, but these errors were encountered: