Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Boot applications built with Maven use the -parameters compiler flag by default #9323

Closed
bclozel opened this issue May 25, 2017 · 3 comments
Assignees
Labels
type: enhancement A general enhancement type: task A general task
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented May 25, 2017

In #9297 we're considering adding jackson modules to our web starter. One of those modules, the parameter-names one, is only useful if the JDK compiler has the -parameters option set.

This issue is about checking the various places where this option should be set.

@bclozel bclozel added theme: build type: task A general task type: enhancement A general enhancement labels May 25, 2017
@snicoll
Copy link
Member

snicoll commented May 29, 2017

So the best we can do now MCOMPILER-298 is fixed is wait for the next release of the maven-compiler-plugin and add the parameters flag to it.

@snicoll snicoll added the status: blocked An issue that's blocked on an external project change label May 29, 2017
@snicoll snicoll changed the title Check that Boot applications are built with the -parameters compiler flag Ensure that Boot applications are built with the -parameters compiler flag by default May 29, 2017
@philwebb philwebb added this to the 2.0.0.M5 milestone Jun 13, 2017
@philwebb
Copy link
Member

philwebb commented Jun 13, 2017

This is super nice when combined with Jackson Java 8 support.

For now, this works:

<plugin>
	<groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-compiler-plugin</artifactId>
	<configuration>
		<compilerArgument>-parameters</compilerArgument>
	</configuration>
</plugin>

@wilkinsona wilkinsona changed the title Ensure that Boot applications are built with the -parameters compiler flag by default Ensure that Boot applications built with Maven use the -parameters compiler flag by default Jul 21, 2017
@snicoll snicoll modified the milestones: 2.0.0.M4, 2.0.0.M5 Jul 24, 2017
@snicoll
Copy link
Member

snicoll commented Jul 26, 2017

The vote for the maven-compiler-plugin 3.6.2 release has started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement type: task A general task
Projects
None yet
Development

No branches or pull requests

3 participants