Repository method override not picked up

[sbont]

Using Spring Boot Data 3.0.6, with Kotlin.
I have a UserRepository extending a CrudRepository, with a method override

@RestResource
override fun findById(id: Long): Optional<User>

My default method exposure is disabled.
When I call my REST endpoint on /users/123 I get a 405 Method Not Allowed. If I enable method exposure, the default implementation from CrudRepository is being picked up instead of my custom declared repository method.

If I declare a custom findAll(), this gets picked up without issues.
I did some digging and it seems that in DefaultCrudMethods.selectMostSuitableFindOneMethod(...) it fails to find the custom interface method, it however does find the CrudRepository one. It calls ReflectionUtils.findMethod(UserRepository.class, "findById", Long.class), and there the comparison of parameter types somehow fails.

[christophstrobl]

The signatures do not match because the id parameter of CrudRepository is considered non nullable, thus the Kotlin signature of the override uses long instead of Long.

[christophstrobl]

We could change the lookup to something like the following which worked for the given example.

return Optional.ofNullable(ReflectionUtils.findMethod(type, name, parameterTypes)).or(() -> {
    return stream(type.getDeclaredMethods()).filter(it -> it.getName().equals(name) && it.getParameterCount() == parameterTypes
            .filter(it -> {
                for(int i = 0; i<it.getParameterCount(); i++) {
                    Class<?> currentParameterType = it.getParameterTypes()[i];
                    if(currentParameterType != parameterTypes[i] && ClassUtils.isPrimitiveWrapper(currentParameterType)) {
                        if(!ClassUtils.isAssignable(parameterTypes[i], currentParameterType)) {
                            return false;
                        }
                    }
                }
                return true;
            })
            .findFirst();
});

[KimJejun]

can u try like this?

@Repository
@JvmDefaultWithCompatibility
inteface UserRepository: CrudRepository<User, Long> {
    override fun findAll(): MutableIterable<User> {
        throw UnsupportedOperationException()
    }
}

@christophstrobl Is working progress?

[sttomm]

I am struggling with the same issue. I first disabled Kotlin warnings as errors and defined the parameter as nullable findById(@Param("id") id: Long?). With that change the overriden findById works fine and I can access the endpoint. But I now finally want to enable warnings again and can't find a working solution.

What I am doing regarding customization is adding a PreAuthorize annotation to it.

@RestResource
@PreAuthorize("hasAuthority('MY_AUTHORIY')")
override fun findById(@Param("id") id: Long): Optional<PlatformInstanceNotification>

[xanscale]

after some hours of experiment the best solution i found is to use UUID :)

@Id @GeneratedValue(strategy = GenerationType.UUID) val id: UUID,

and it works perfectly