Skip to content

Fix typo in example code #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix typo in example code #3224

wants to merge 1 commit into from
+1 −1

Conversation

seate
Copy link
Contributor

@seate seate commented Dec 29, 2024

fixed missing parameter in example code

Before

List<User> findByLastname(Limit limit);

After

List<User> findByLastname(String lastname, Limit limit);

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 29, 2024
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 13, 2025
@mp911de mp911de self-assigned this Jan 13, 2025
@mp911de mp911de assigned onobc and unassigned mp911de Apr 11, 2025
onobc pushed a commit to onobc/spring-data-commons that referenced this pull request Apr 11, 2025
@ngocnhan-tran1996 @onobc
Remove unused imports.
4e3955b 
This cleans up a couple of classes by removing unused imports.

Original pull request: spring-projects#3224

Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@onobc
Copy link

onobc commented Apr 14, 2025

Thanks for the cleanup @seate . However, before we merge it can you please add a Signed-off-by trailer at the bottom of the commit message to agree to the DCO.

@seate seate force-pushed the fix-typo branch 3 times, most recently from 5948a40 to c24d85d Compare April 15, 2025 01:41
@seate
fix typo in example code
28c1957 
fixed typo in example code

Signed-off-by: KIMSIWOO <sa20207@naver.com>
@seate
Copy link
Contributor Author

seate commented Apr 15, 2025

@onobc I appended Signed-off-by to the commit message. Please check it.

@onobc
Copy link

onobc commented Apr 16, 2025

Thanks for the contribution @seate . Closing in favor of 85a4dc5

@onobc onobc closed this Apr 16, 2025
onobc pushed a commit to onobc/spring-data-commons that referenced this pull request Apr 16, 2025
@seate @onobc
Fix example code in query methods details doc.
c0b60b2 
Original pull request: spring-projects#3224

Signed-off-by: KIMSIWOO <sa20207@naver.com>
onobc pushed a commit that referenced this pull request Apr 16, 2025
@seate @onobc
Fix example code in query methods details doc.
80272e6 
Original pull request: #3224

Signed-off-by: KIMSIWOO <sa20207@naver.com>
(cherry picked from commit c0b60b2)
onobc pushed a commit that referenced this pull request Apr 16, 2025
@seate @onobc
Fix example code in query methods details doc.
b064b69 
Original pull request: #3224

Signed-off-by: KIMSIWOO <sa20207@naver.com>
(cherry picked from commit c0b60b2)
@onobc
Copy link

onobc commented Apr 16, 2025

Backported to 3.3.x and 3.4.x

@mp911de mp911de added this to the 3.3.11 (2024.0.11) milestone Apr 17, 2025
@mp911de mp911de changed the title fix typo in example code Fix typo in example code Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@onobc onobc

Labels
type: documentation A documentation update
Projects
None yet
Milestone
3.3.11 (2024.0.11)
Development

Successfully merging this pull request may close these issues.
4 participants
@seate @onobc @mp911de @spring-projects-issues