Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for retrieving request executionDuration. #2991

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for retrieving request executionDuration. #2991

wants to merge 2 commits into from

Conversation

ELHARROUGUI
Copy link

Please let me know if I missed anything.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker. Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #2986

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 19, 2024
@ELHARROUGUI
Add support for retrieving request executionDuration.
24b2a8a 
Added support for retreving the query execution time from took() method of ResponseBody class as java.time.Duration in SearchDocumentResponseBuilder class.

Closes spring-projects#2986
sothawo
sothawo requested changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@sothawo sothawo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for that PR; 2 changes to do

pom.xml Outdated Show resolved Hide resolved
src/test/java/org/springframework/data/elasticsearch/core/ElasticsearchIntegrationTests.java Show resolved Hide resolved
@ELHARROUGUI
Add support for retrieving request executionDuration.
bd1a469 
Added support for retreving the query execution time from took() method of ResponseBody class as java.time.Duration in SearchDocumentResponseBuilder class.

Closes spring-projects#2986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sothawo sothawo Awaiting requested review from sothawo

Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "took" attribute to SearchHits/ReactiveSearchHits
3 participants
@ELHARROUGUI @sothawo @spring-projects-issues