Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubscript redis listener on subscript task run occured exception [DATAREDIS-231] #808

Closed
spring-projects-issues opened this issue Jul 31, 2013 · 2 comments
Labels
type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link

jokeway opened DATAREDIS-231 and commented

When Subscript task occured exception( Network problem/Redis server start etc.), the subscript task will abort run method and the whole listener thread will exist.

In the production environment, it is better to reconnection and resubscript


Affects: 1.1.0.M1

Reference URL: #11

@spring-projects-issues
Copy link
Author

Jennifer Hickey commented

I do agree we should have this functionality. I'll comment on the PR individually, but do want to note that the fix will only work when using Jedis. SRP and Lettuce don't block on the subscribe call, so that Thread wouldn't even be running when the Redis server went down. Lettuce reconnects Subscriptions automatically, so this already works. I need to research the best way to handle this with SRP, as currently there is no indication that the subscription was lost on Redis restart

@spring-projects-issues
Copy link
Author

Jennifer Hickey commented

Opened this issue for SRP: spullara/redis-protocol#32

We will go ahead and implement the Jedis case in this release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant