Skip to content

Commit 61c6fcf

Browse files
committed
Polishing.
Reduce test element visibility. See #1750 Original pull request: #1785
1 parent 9e8e3ce commit 61c6fcf

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/core/convert/MappingJdbcConverterUnitTests.java

+16-15
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,16 @@
5656
* @author Mark Paluch
5757
* @author Jens Schauder
5858
*/
59-
public class MappingJdbcConverterUnitTests {
59+
class MappingJdbcConverterUnitTests {
6060

61-
public static final UUID UUID = java.util.UUID.fromString("87a48aa8-a071-705e-54a9-e52fe3a012f1");
62-
public static final byte[] BYTES_REPRESENTING_UUID = { -121, -92, -118, -88, -96, 113, 112, 94, 84, -87, -27, 47, -29,
61+
private static final UUID UUID = java.util.UUID.fromString("87a48aa8-a071-705e-54a9-e52fe3a012f1");
62+
private static final byte[] BYTES_REPRESENTING_UUID = { -121, -92, -118, -88, -96, 113, 112, 94, 84, -87, -27, 47,
63+
-29,
6364
-96, 18, -15 };
6465

65-
JdbcMappingContext context = new JdbcMappingContext();
66-
StubbedJdbcTypeFactory typeFactory = new StubbedJdbcTypeFactory();
67-
MappingJdbcConverter converter = new MappingJdbcConverter( //
66+
private JdbcMappingContext context = new JdbcMappingContext();
67+
private StubbedJdbcTypeFactory typeFactory = new StubbedJdbcTypeFactory();
68+
private MappingJdbcConverter converter = new MappingJdbcConverter( //
6869
context, //
6970
(identifier, path) -> {
7071
throw new UnsupportedOperationException();
@@ -74,7 +75,7 @@ public class MappingJdbcConverterUnitTests {
7475
);
7576

7677
@Test // DATAJDBC-104, DATAJDBC-1384
77-
public void testTargetTypesForPropertyType() {
78+
void testTargetTypesForPropertyType() {
7879

7980
RelationalPersistentEntity<?> entity = context.getRequiredPersistentEntity(DummyEntity.class);
8081

@@ -95,7 +96,7 @@ public void testTargetTypesForPropertyType() {
9596
}
9697

9798
@Test // DATAJDBC-259
98-
public void classificationOfCollectionLikeProperties() {
99+
void classificationOfCollectionLikeProperties() {
99100

100101
RelationalPersistentEntity<?> entity = context.getRequiredPersistentEntity(DummyEntity.class);
101102

@@ -111,7 +112,7 @@ public void classificationOfCollectionLikeProperties() {
111112
}
112113

113114
@Test // DATAJDBC-221
114-
public void referencesAreNotEntitiesAndGetStoredAsTheirId() {
115+
void referencesAreNotEntitiesAndGetStoredAsTheirId() {
115116

116117
RelationalPersistentEntity<?> entity = context.getRequiredPersistentEntity(DummyEntity.class);
117118

@@ -176,7 +177,7 @@ void readByteArrayToNestedUuidWithCustomConverter() {
176177
typeFactory //
177178
);
178179

179-
SoftAssertions.assertSoftly(softly -> {
180+
assertSoftly(softly -> {
180181
checkReadConversion(softly, converter, "uuidRef", AggregateReference.to(UUID));
181182
checkReadConversion(softly, converter, "uuid", UUID);
182183
checkReadConversion(softly, converter, "optionalUuid", Optional.of(UUID));
@@ -337,7 +338,7 @@ private enum SomeEnum {
337338
private static class OtherEntity {}
338339

339340
private static class StubbedJdbcTypeFactory implements JdbcTypeFactory {
340-
public Object[] arraySource;
341+
Object[] arraySource;
341342

342343
@Override
343344
public Array createArray(Object[] value) {
@@ -346,16 +347,16 @@ public Array createArray(Object[] value) {
346347
}
347348
}
348349

349-
record WithOneToOne(@Id String id, @MappedCollection(idColumn = "renamed") Referenced referenced) {
350+
private record WithOneToOne(@Id String id, @MappedCollection(idColumn = "renamed") Referenced referenced) {
350351
}
351352

352-
record Referenced(@Id Long id) {
353+
private record Referenced(@Id Long id) {
353354
}
354355

355-
record ReferencedByUuid(@Id UUID id) {
356+
private record ReferencedByUuid(@Id UUID id) {
356357
}
357358

358-
class ByteArrayToUuid implements Converter<byte[], UUID> {
359+
static class ByteArrayToUuid implements Converter<byte[], UUID> {
359360
@Override
360361
public UUID convert(byte[] source) {
361362

0 commit comments

Comments
 (0)