fixed accidental test failures

Author: jhoeller

org.springframework.beans/src/main/java/org/springframework/beans/TypeConverterDelegate.java

@@ -437,6 +437,16 @@ else if (input.getClass().isArray()) {
 	protected Collection convertToTypedCollection(
 			Collection original, String propertyName, Class requiredType, MethodParameter methodParam) {
 
+		boolean originalAllowed = requiredType.isInstance(original);
+		Class elementType = null;
+		if (methodParam != null) {
+			elementType = GenericCollectionTypeResolver.getCollectionParameterType(methodParam);
+		}
+		if (elementType == null && originalAllowed &&
+				!this.propertyEditorRegistry.hasCustomEditorForElement(null, propertyName)) {
+			return original;
+		}
+
 		Iterator it;
 		try {
 			it = original.iterator();
@@ -473,16 +483,6 @@ protected Collection convertToTypedCollection(
 			return original;
 		}
 
-		boolean originalAllowed = requiredType.isInstance(original);
-		Class elementType = null;
-		if (methodParam != null) {
-			elementType = GenericCollectionTypeResolver.getCollectionParameterType(methodParam);
-		}
-		if (elementType == null && originalAllowed &&
-				!this.propertyEditorRegistry.hasCustomEditorForElement(null, propertyName)) {
-			return original;
-		}
-
 		int i = 0;
 		for (; it.hasNext(); i++) {
 			Object element = it.next();
@@ -503,6 +503,18 @@ protected Collection convertToTypedCollection(
 
 	@SuppressWarnings("unchecked")
 	protected Map convertToTypedMap(Map original, String propertyName, Class requiredType, MethodParameter methodParam) {
+		boolean originalAllowed = requiredType.isInstance(original);
+		Class keyType = null;
+		Class valueType = null;
+		if (methodParam != null) {
+			keyType = GenericCollectionTypeResolver.getMapKeyParameterType(methodParam);
+			valueType = GenericCollectionTypeResolver.getMapValueParameterType(methodParam);
+		}
+		if (keyType == null && valueType == null && originalAllowed &&
+				!this.propertyEditorRegistry.hasCustomEditorForElement(null, propertyName)) {
+			return original;
+		}
+
 		Iterator it;
 		try {
 			it = original.entrySet().iterator();
@@ -539,18 +551,6 @@ protected Map convertToTypedMap(Map original, String propertyName, Class require
 			return original;
 		}
 
-		boolean originalAllowed = requiredType.isInstance(original);
-		Class keyType = null;
-		Class valueType = null;
-		if (methodParam != null) {
-			keyType = GenericCollectionTypeResolver.getMapKeyParameterType(methodParam);
-			valueType = GenericCollectionTypeResolver.getMapValueParameterType(methodParam);
-		}
-		if (keyType == null && valueType == null && originalAllowed &&
-				!this.propertyEditorRegistry.hasCustomEditorForElement(null, propertyName)) {
-			return original;
-		}
-
 		while (it.hasNext()) {
 			Map.Entry entry = (Map.Entry) it.next();
 			Object key = entry.getKey();

org.springframework.beans/src/test/java/test/beans/DerivedTestBean.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2007 the original author or authors.
+ * Copyright 2002-2009 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -60,6 +60,10 @@ public String getBeanName() {
 		return beanName;
 	}
 
+	public void setActualSpouse(TestBean spouse) {
+		setSpouse(spouse);
+	}
+
 	public void setSpouseRef(String name) {
 		setSpouse(new TestBean(name));
 	}
@@ -82,4 +86,4 @@ public boolean wasDestroyed() {
 		return destroyed;
 	}
 
-}
+}

org.springframework.beans/src/test/java/test/beans/TestBean.java

@@ -200,10 +200,6 @@ public void setSpouse(ITestBean spouse) {
 		this.spouses = new ITestBean[] {spouse};
 	}
 
-	public void setActualSpouse(TestBean spouse) {
-		this.spouses = new ITestBean[] {spouse};
-	}
-
 	public ITestBean getSpouse() {
 		return (spouses != null ? spouses[0] : null);
 	}

org.springframework.beans/src/test/resources/org/springframework/beans/factory/xml/collections.xml

@@ -44,7 +44,7 @@
 		</property>
 	</bean>
 
-	<bean id="pDavid" class="test.beans.TestBean" scope="prototype">
+	<bean id="pDavid" class="test.beans.DerivedTestBean" scope="prototype">
 		<property name="name"><value>David</value></property>
 		<property name="age"><value>27</value></property>
 		<property name="actualSpouse" value="Jen"/>