Migrate remaining JUnit 4 tests to JUnit Jupiter where feasible

In 49e5c84 I unfortunately overlooked
several JUnit 4 based tests in the `junit4` package that should be
migrated to JUnit Jupiter.

This commit address those remaining test classes.

See gh-23451
See gh-34794
Closes gh-34813

Author: sbrannen

spring-test/src/test/java/org/springframework/test/context/aot/AotIntegrationTests.java

@@ -167,7 +167,6 @@ void endToEndTestsForBeanOverrides() {
 	void endToEndTestsForSelectedTestClasses() {
 		List<Class<?>> testClasses = List.of(
 				org.springframework.test.context.bean.override.easymock.EasyMockBeanIntegrationTests.class,
-				org.springframework.test.context.junit4.SpringJUnit4ClassRunnerAppCtxTests.class,
 				org.springframework.test.context.junit4.ParameterizedDependencyInjectionTests.class
 		);
 

spring-test/src/test/java/org/springframework/test/context/cache/SpringExtensionContextCacheTests.java

@@ -47,7 +47,7 @@
  * @see ContextCacheTests
  * @see LruContextCacheTests
  */
-@SpringJUnitConfig(locations = "../junit4/SpringJUnit4ClassRunnerAppCtxTests-context.xml")
+@SpringJUnitConfig(locations = "../config/CoreContextConfigurationAppCtxTests-context.xml")
 @TestExecutionListeners({ DependencyInjectionTestExecutionListener.class, DirtiesContextTestExecutionListener.class })
 @TestMethodOrder(MethodOrderer.OrderAnnotation.class)
 class SpringExtensionContextCacheTests {

spring-test/src/test/java/org/springframework/test/context/junit4/AbsolutePathSpringJUnit4ClassRunnerAppCtxTests.java renamed to spring-test/src/test/java/org/springframework/test/context/config/AbsolutePathContextConfigurationAppCtxTests.java

@@ -14,22 +14,22 @@
  * limitations under the License.
  */
 
-package org.springframework.test.context.junit4;
+package org.springframework.test.context.config;
 
 import org.springframework.test.context.ContextConfiguration;
 
 /**
- * Extension of {@link SpringJUnit4ClassRunnerAppCtxTests}, which verifies that
+ * Extension of {@link CoreContextConfigurationAppCtxTests}, which verifies that
  * we can specify an explicit, <em>absolute path</em> location for our
  * application context.
  *
  * @author Sam Brannen
  * @since 2.5
- * @see SpringJUnit4ClassRunnerAppCtxTests
- * @see ClassPathResourceSpringJUnit4ClassRunnerAppCtxTests
- * @see RelativePathSpringJUnit4ClassRunnerAppCtxTests
+ * @see CoreContextConfigurationAppCtxTests
+ * @see ClassPathResourceContextConfigurationAppCtxTests
+ * @see RelativePathContextConfigurationAppCtxTests
  */
-@ContextConfiguration(locations = { SpringJUnit4ClassRunnerAppCtxTests.DEFAULT_CONTEXT_RESOURCE_PATH }, inheritLocations = false)
-public class AbsolutePathSpringJUnit4ClassRunnerAppCtxTests extends SpringJUnit4ClassRunnerAppCtxTests {
+@ContextConfiguration(locations = CoreContextConfigurationAppCtxTests.DEFAULT_CONTEXT_RESOURCE_PATH, inheritLocations = false)
+class AbsolutePathContextConfigurationAppCtxTests extends CoreContextConfigurationAppCtxTests {
 	/* all tests are in the parent class. */
 }

spring-test/src/test/java/org/springframework/test/context/junit4/AnnotationConfigSpringJUnit4ClassRunnerAppCtxTests.java renamed to spring-test/src/test/java/org/springframework/test/context/config/AnnotationConfigContextConfigurationAppCtxTests.java

@@ -14,26 +14,25 @@
  * limitations under the License.
  */
 
-package org.springframework.test.context.junit4;
+package org.springframework.test.context.config;
 
 import org.springframework.test.context.ContextConfiguration;
-import org.springframework.test.context.annotation.PojoAndStringConfig;
 
 /**
  * Integration tests that verify support for configuration classes in
  * the Spring TestContext Framework.
  *
- * <p>Furthermore, by extending {@code SpringJUnit4ClassRunnerAppCtxTests},
+ * <p>Furthermore, by extending {@link CoreContextConfigurationAppCtxTests},
  * this class also verifies support for several basic features of the
  * Spring TestContext Framework. See JavaDoc in
- * {@link SpringJUnit4ClassRunnerAppCtxTests} for details.
+ * {@link CoreContextConfigurationAppCtxTests} for details.
  *
  * <p>Configuration will be loaded from {@link PojoAndStringConfig}.
  *
  * @author Sam Brannen
  * @since 3.1
  */
 @ContextConfiguration(classes = PojoAndStringConfig.class, inheritLocations = false)
-public class AnnotationConfigSpringJUnit4ClassRunnerAppCtxTests extends SpringJUnit4ClassRunnerAppCtxTests {
+class AnnotationConfigContextConfigurationAppCtxTests extends CoreContextConfigurationAppCtxTests {
 	/* all tests are in the parent class. */
 }

spring-test/src/test/java/org/springframework/test/context/AutowiredQualifierTests.java renamed to spring-test/src/test/java/org/springframework/test/context/config/AutowiredQualifierTests.java

@@ -14,13 +14,17 @@
  * limitations under the License.
  */
 
-package org.springframework.test.context;
+package org.springframework.test.context.config;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
 
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Qualifier;
-import org.springframework.test.context.junit.jupiter.SpringJUnitConfig;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.test.context.ContextConfiguration;
+import org.springframework.test.context.junit.jupiter.SpringExtension;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
@@ -32,15 +36,16 @@
  * @author Chris Beams
  * @since 3.0
  */
-@SpringJUnitConfig
+@ExtendWith(SpringExtension.class)
+@ContextConfiguration
 class AutowiredQualifierTests {
 
 	@Autowired
-	private String foo;
+	String foo;
 
 	@Autowired
 	@Qualifier("customFoo")
-	private String customFoo;
+	String customFoo;
 
 
 	@Test
@@ -49,4 +54,19 @@ void test() {
 		assertThat(customFoo).isEqualTo("custom");
 	}
 
+
+	@Configuration(proxyBeanMethods = false)
+	static class Config {
+
+		@Bean
+		String foo() {
+			return "normal";
+		}
+
+		@Bean
+		String customFoo() {
+			return "custom";
+		}
+	}
+
 }

spring-test/src/test/java/org/springframework/test/context/annotation/BeanOverridingDefaultConfigClassesInheritedTests.java renamed to spring-test/src/test/java/org/springframework/test/context/config/BeanOverridingDefaultConfigClassesInheritedTests.java

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package org.springframework.test.context.annotation;
+package org.springframework.test.context.config;
 
 import org.junit.jupiter.api.Test;
 

spring-test/src/test/java/org/springframework/test/context/annotation/BeanOverridingExplicitConfigClassesInheritedTests.java renamed to spring-test/src/test/java/org/springframework/test/context/config/BeanOverridingExplicitConfigClassesInheritedTests.java

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package org.springframework.test.context.annotation;
+package org.springframework.test.context.config;
 
 import org.junit.jupiter.api.Test;
 

spring-test/src/test/java/org/springframework/test/context/junit4/ClassPathResourceSpringJUnit4ClassRunnerAppCtxTests.java renamed to spring-test/src/test/java/org/springframework/test/context/config/ClassPathResourceContextConfigurationAppCtxTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2024 the original author or authors.
+ * Copyright 2002-2025 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -14,36 +14,35 @@
  * limitations under the License.
  */
 
-package org.springframework.test.context.junit4;
+package org.springframework.test.context.config;
 
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.util.ResourceUtils;
 
 /**
- * Extension of {@link SpringJUnit4ClassRunnerAppCtxTests}, which verifies that
+ * Extension of {@link CoreContextConfigurationAppCtxTests}, which verifies that
  * we can specify an explicit, <em>classpath</em> location for our application
  * context.
  *
  * @author Sam Brannen
  * @since 2.5
- * @see SpringJUnit4ClassRunnerAppCtxTests
+ * @see CoreContextConfigurationAppCtxTests
  * @see #CLASSPATH_CONTEXT_RESOURCE_PATH
- * @see AbsolutePathSpringJUnit4ClassRunnerAppCtxTests
- * @see RelativePathSpringJUnit4ClassRunnerAppCtxTests
+ * @see AbsolutePathContextConfigurationAppCtxTests
+ * @see RelativePathContextConfigurationAppCtxTests
  */
-@ContextConfiguration(locations = { ClassPathResourceSpringJUnit4ClassRunnerAppCtxTests.CLASSPATH_CONTEXT_RESOURCE_PATH }, inheritLocations = false)
-public class ClassPathResourceSpringJUnit4ClassRunnerAppCtxTests extends SpringJUnit4ClassRunnerAppCtxTests {
+@ContextConfiguration(locations = { ClassPathResourceContextConfigurationAppCtxTests.CLASSPATH_CONTEXT_RESOURCE_PATH }, inheritLocations = false)
+class ClassPathResourceContextConfigurationAppCtxTests extends CoreContextConfigurationAppCtxTests {
 
 	/**
 	 * Classpath-based resource path for the application context configuration
-	 * for {@link SpringJUnit4ClassRunnerAppCtxTests}:
-	 * {@code &quot;classpath:/org/springframework/test/context/junit4/SpringJUnit4ClassRunnerAppCtxTests-context.xml&quot;}
+	 * for {@link CoreContextConfigurationAppCtxTests}: {@value}
 	 *
-	 * @see SpringJUnit4ClassRunnerAppCtxTests#DEFAULT_CONTEXT_RESOURCE_PATH
+	 * @see CoreContextConfigurationAppCtxTests#DEFAULT_CONTEXT_RESOURCE_PATH
 	 * @see ResourceUtils#CLASSPATH_URL_PREFIX
 	 */
 	public static final String CLASSPATH_CONTEXT_RESOURCE_PATH = ResourceUtils.CLASSPATH_URL_PREFIX +
-			SpringJUnit4ClassRunnerAppCtxTests.DEFAULT_CONTEXT_RESOURCE_PATH;
+			CoreContextConfigurationAppCtxTests.DEFAULT_CONTEXT_RESOURCE_PATH;
 
 	/* all tests are in the parent class. */
 

spring-test/src/test/java/org/springframework/test/context/annotation/AnnotationConfigTestSuite.java renamed to spring-test/src/test/java/org/springframework/test/context/config/ContextConfigTestSuite.java

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package org.springframework.test.context.annotation;
+package org.springframework.test.context.config;
 
 import org.junit.jupiter.api.ClassOrderer;
 import org.junit.platform.suite.api.ConfigurationParameter;
@@ -44,11 +44,11 @@
  */
 @Suite
 @IncludeEngines("junit-jupiter")
-@SelectPackages("org.springframework.test.context.annotation")
+@SelectPackages("org.springframework.test.context.config")
 @IncludeClassNamePatterns(".*Tests$")
 @ConfigurationParameter(
 	key = ClassOrderer.DEFAULT_ORDER_PROPERTY_NAME,
 	value = "org.junit.jupiter.api.ClassOrderer$ClassName"
 )
-public class AnnotationConfigTestSuite {
+public class ContextConfigTestSuite {
 }

spring-test/src/test/java/org/springframework/test/context/junit4/SpringJUnit4ClassRunnerAppCtxTests.java renamed to spring-test/src/test/java/org/springframework/test/context/config/CoreContextConfigurationAppCtxTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2024 the original author or authors.
+ * Copyright 2002-2025 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -14,13 +14,13 @@
  * limitations under the License.
  */
 
-package org.springframework.test.context.junit4;
+package org.springframework.test.context.config;
 
 import jakarta.annotation.Resource;
 import jakarta.inject.Inject;
 import jakarta.inject.Named;
-import org.junit.Test;
-import org.junit.runner.RunWith;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
 
 import org.springframework.beans.factory.BeanNameAware;
 import org.springframework.beans.factory.InitializingBean;
@@ -33,18 +33,18 @@
 import org.springframework.context.ApplicationContextAware;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.TestExecutionListeners;
+import org.springframework.test.context.junit.jupiter.SpringExtension;
 import org.springframework.test.context.support.DependencyInjectionTestExecutionListener;
 import org.springframework.test.context.support.GenericXmlContextLoader;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
 /**
- * SpringJUnit4ClassRunnerAppCtxTests serves as a <em>proof of concept</em>
- * JUnit 4 based test class, which verifies the expected functionality of
- * {@link SpringRunner} in conjunction with the following:
+ * {@code CoreContextConfigurationAppCtxTests} serves as a <em>core</em> test class, which
+ * verifies the expected functionality of {@link ContextConfiguration @ContextConfiguration}
+ * in conjunction with the following:
  *
  * <ul>
- * <li>{@link ContextConfiguration @ContextConfiguration}</li>
  * <li>{@link Autowired @Autowired}</li>
  * <li>{@link Qualifier @Qualifier}</li>
  * <li>{@link Resource @Resource}</li>
@@ -67,21 +67,24 @@
  *
  * @author Sam Brannen
  * @since 2.5
- * @see AbsolutePathSpringJUnit4ClassRunnerAppCtxTests
- * @see RelativePathSpringJUnit4ClassRunnerAppCtxTests
- * @see InheritedConfigSpringJUnit4ClassRunnerAppCtxTests
+ * @see AbsolutePathContextConfigurationAppCtxTests
+ * @see AnnotationConfigContextConfigurationAppCtxTests
+ * @see ClassPathResourceContextConfigurationAppCtxTests
+ * @see InheritedConfigContextConfigurationAppCtxTests
+ * @see MultipleResourcesContextConfigurationAppCtxTests
+ * @see RelativePathContextConfigurationAppCtxTests
  */
-@RunWith(SpringRunner.class)
+@ExtendWith(SpringExtension.class)
 @ContextConfiguration
 @TestExecutionListeners(DependencyInjectionTestExecutionListener.class)
-public class SpringJUnit4ClassRunnerAppCtxTests implements ApplicationContextAware, BeanNameAware, InitializingBean {
+class CoreContextConfigurationAppCtxTests implements ApplicationContextAware, BeanNameAware, InitializingBean {
 
 	/**
 	 * Default resource path for the application context configuration for
-	 * {@link SpringJUnit4ClassRunnerAppCtxTests}: {@value}
+	 * {@link CoreContextConfigurationAppCtxTests}: {@value}
 	 */
 	public static final String DEFAULT_CONTEXT_RESOURCE_PATH =
-			"/org/springframework/test/context/junit4/SpringJUnit4ClassRunnerAppCtxTests-context.xml";
+			"/org/springframework/test/context/config/CoreContextConfigurationAppCtxTests-context.xml";
 
 
 	private Employee employee;
@@ -136,12 +139,12 @@ protected void setBar(String bar) {
 	}
 
 	@Autowired
-	public void setLiteralParameterValue(@Value("enigma") String literalParameterValue) {
+	void setLiteralParameterValue(@Value("enigma") String literalParameterValue) {
 		this.literalParameterValue = literalParameterValue;
 	}
 
 	@Autowired
-	public void setSpelParameterValue(@Value("#{2 == (1+1)}") Boolean spelParameterValue) {
+	void setSpelParameterValue(@Value("#{2 == (1+1)}") Boolean spelParameterValue) {
 		this.spelParameterValue = spelParameterValue;
 	}
 
@@ -162,23 +165,23 @@ public void afterPropertiesSet() {
 
 
 	@Test
-	public void verifyBeanNameSet() {
+	void verifyBeanNameSet() {
 		assertThat(this.beanName).as("The bean name of this test instance should have been set due to BeanNameAware semantics.")
 				.startsWith(getClass().getName());
 	}
 
 	@Test
-	public void verifyApplicationContextSet() {
+	void verifyApplicationContextSet() {
 		assertThat(this.applicationContext).as("The application context should have been set due to ApplicationContextAware semantics.").isNotNull();
 	}
 
 	@Test
-	public void verifyBeanInitialized() {
+	void verifyBeanInitialized() {
 		assertThat(this.beanInitialized).as("This test bean should have been initialized due to InitializingBean semantics.").isTrue();
 	}
 
 	@Test
-	public void verifyAnnotationAutowiredAndInjectedFields() {
+	void verifyAnnotationAutowiredAndInjectedFields() {
 		assertThat(this.nonrequiredLong).as("The nonrequiredLong field should NOT have been autowired.").isNull();
 		assertThat(this.quux).as("The quux field should have been autowired via @Autowired and @Qualifier.").isEqualTo("Quux");
 		assertThat(this.namedQuux).as("The namedFoo field should have been injected via @Inject and @Named.").isEqualTo("Quux");
@@ -192,34 +195,34 @@ public void verifyAnnotationAutowiredAndInjectedFields() {
 	}
 
 	@Test
-	public void verifyAnnotationAutowiredMethods() {
+	void verifyAnnotationAutowiredMethods() {
 		assertThat(this.employee).as("The employee setter method should have been autowired.").isNotNull();
 		assertThat(this.employee.getName()).isEqualTo("John Smith");
 	}
 
 	@Test
-	public void verifyAutowiredAtValueFields() {
+	void verifyAutowiredAtValueFields() {
 		assertThat(this.literalFieldValue).as("Literal @Value field should have been autowired").isNotNull();
 		assertThat(this.spelFieldValue).as("SpEL @Value field should have been autowired.").isNotNull();
 		assertThat(this.literalFieldValue).isEqualTo("enigma");
 		assertThat(this.spelFieldValue).isTrue();
 	}
 
 	@Test
-	public void verifyAutowiredAtValueMethods() {
+	void verifyAutowiredAtValueMethods() {
 		assertThat(this.literalParameterValue).as("Literal @Value method parameter should have been autowired.").isNotNull();
 		assertThat(this.spelParameterValue).as("SpEL @Value method parameter should have been autowired.").isNotNull();
 		assertThat(this.literalParameterValue).isEqualTo("enigma");
 		assertThat(this.spelParameterValue).isTrue();
 	}
 
 	@Test
-	public void verifyResourceAnnotationInjectedFields() {
+	void verifyResourceAnnotationInjectedFields() {
 		assertThat(this.foo).as("The foo field should have been injected via @Resource.").isEqualTo("Foo");
 	}
 
 	@Test
-	public void verifyResourceAnnotationInjectedMethods() {
+	void verifyResourceAnnotationInjectedMethods() {
 		assertThat(this.bar).as("The bar method should have been wired via @Resource.").isEqualTo("Bar");
 	}