Skip to content

Commit 1de7151

Browse files
committed
Merge pull request #702 from aantono/master
Fix for NPE when creating ProtobufHttpMessageConverter without ExtensionRegistryInitializer
2 parents d322bcf + b041cff commit 1de7151

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

spring-web/src/main/java/org/springframework/http/converter/protobuf/ProtobufHttpMessageConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public ProtobufHttpMessageConverter() {
8686
*/
8787
public ProtobufHttpMessageConverter(ExtensionRegistryInitializer registryInitializer) {
8888
super(PROTOBUF, MediaType.TEXT_PLAIN, MediaType.APPLICATION_XML, MediaType.APPLICATION_JSON);
89-
if (this.extensionRegistry != null) {
89+
if (registryInitializer != null) {
9090
registryInitializer.initializeExtensionRegistry(this.extensionRegistry);
9191
}
9292
}

spring-web/src/test/java/org/springframework/http/converter/protobuf/ProtobufHttpMessageConverterTests.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,15 @@ public void extensionRegistryInitialized() {
5858
verify(this.registryInitializer, times(1)).initializeExtensionRegistry(anyObject());
5959
}
6060

61+
@Test
62+
public void extensionRegistryNull() {
63+
try {
64+
new ProtobufHttpMessageConverter(null);
65+
} catch (Exception e) {
66+
fail("Unable to create ProtobufHttpMessageConverter with null extensionRegistry");
67+
}
68+
}
69+
6170
@Test
6271
public void canRead() {
6372
assertTrue(this.converter.canRead(Msg.class, null));

0 commit comments

Comments
 (0)