Skip to content

Commit 220995b

Browse files
committed
Move HandlerMethodValidator to web.method.annotation package
Avoiding cycle between web.method.support and web.method.annotation packages. See gh-29825
1 parent e344f3f commit 220995b

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

spring-web/src/main/java/org/springframework/web/method/support/HandlerMethodValidator.java renamed to spring-web/src/main/java/org/springframework/web/method/annotation/HandlerMethodValidator.java

+2-4
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.web.method.support;
17+
package org.springframework.web.method.annotation;
1818

1919
import java.lang.reflect.Method;
2020

@@ -35,7 +35,6 @@
3535
import org.springframework.web.bind.annotation.RequestPart;
3636
import org.springframework.web.bind.support.ConfigurableWebBindingInitializer;
3737
import org.springframework.web.bind.support.WebBindingInitializer;
38-
import org.springframework.web.method.annotation.ModelFactory;
3938

4039
/**
4140
* {@link org.springframework.validation.beanvalidation.MethodValidator} for
@@ -48,7 +47,6 @@
4847
*/
4948
public final class HandlerMethodValidator extends DefaultMethodValidator {
5049

51-
5250
private HandlerMethodValidator(MethodValidationAdapter adapter) {
5351
super(adapter);
5452
}
@@ -86,7 +84,7 @@ private String determineObjectName(MethodParameter param, @Nullable Object argum
8684
return Conventions.getVariableNameForParameter(param);
8785
}
8886
else {
89-
return ((param.getParameterIndex() != -1) ?
87+
return (param.getParameterIndex() != -1 ?
9088
ModelFactory.getNameForParameter(param) :
9189
ModelFactory.getNameForReturnValue(argument, param));
9290
}

spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestMappingHandlerAdapter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
import org.springframework.validation.beanvalidation.MethodValidator;
3939
import org.springframework.web.bind.support.WebBindingInitializer;
4040
import org.springframework.web.method.HandlerMethod;
41-
import org.springframework.web.method.support.HandlerMethodValidator;
41+
import org.springframework.web.method.annotation.HandlerMethodValidator;
4242
import org.springframework.web.reactive.BindingContext;
4343
import org.springframework.web.reactive.DispatchExceptionHandler;
4444
import org.springframework.web.reactive.HandlerAdapter;

spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@
7474
import org.springframework.web.method.HandlerMethod;
7575
import org.springframework.web.method.annotation.ErrorsMethodArgumentResolver;
7676
import org.springframework.web.method.annotation.ExpressionValueMethodArgumentResolver;
77+
import org.springframework.web.method.annotation.HandlerMethodValidator;
7778
import org.springframework.web.method.annotation.InitBinderDataBinderFactory;
7879
import org.springframework.web.method.annotation.MapMethodProcessor;
7980
import org.springframework.web.method.annotation.ModelFactory;
@@ -88,7 +89,6 @@
8889
import org.springframework.web.method.support.HandlerMethodArgumentResolverComposite;
8990
import org.springframework.web.method.support.HandlerMethodReturnValueHandler;
9091
import org.springframework.web.method.support.HandlerMethodReturnValueHandlerComposite;
91-
import org.springframework.web.method.support.HandlerMethodValidator;
9292
import org.springframework.web.method.support.InvocableHandlerMethod;
9393
import org.springframework.web.method.support.ModelAndViewContainer;
9494
import org.springframework.web.servlet.ModelAndView;

0 commit comments

Comments
 (0)