Skip to content

Commit 23e91e1

Browse files
committed
Consistent use of "URI variables" terminology
Issue: SPR-14969 (cherry picked from commit 2b02935)
1 parent 01214bf commit 23e91e1

File tree

5 files changed

+78
-78
lines changed

5 files changed

+78
-78
lines changed

Diff for: spring-test/src/main/java/org/springframework/test/web/servlet/request/MockHttpServletRequestBuilder.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public class MockHttpServletRequestBuilder
116116
* {@link #with(RequestPostProcessor)}.
117117
* @param httpMethod the HTTP method (GET, POST, etc)
118118
* @param url a URL template; the resulting URL will be encoded
119-
* @param vars zero or more URL variables
119+
* @param vars zero or more URI variables
120120
*/
121121
MockHttpServletRequestBuilder(HttpMethod httpMethod, String url, Object... vars) {
122122
this(httpMethod, UriComponentsBuilder.fromUriString(url).buildAndExpand(vars).encode().toUri());

Diff for: spring-test/src/main/java/org/springframework/test/web/servlet/request/MockMultipartHttpServletRequestBuilder.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2015 the original author or authors.
2+
* Copyright 2002-2016 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -46,10 +46,10 @@ public class MockMultipartHttpServletRequestBuilder extends MockHttpServletReque
4646
* see {@link #with(RequestPostProcessor)} and the
4747
* {@link RequestPostProcessor} extension point.
4848
* @param urlTemplate a URL template; the resulting URL will be encoded
49-
* @param urlVariables zero or more URL variables
49+
* @param uriVariables zero or more URI variables
5050
*/
51-
MockMultipartHttpServletRequestBuilder(String urlTemplate, Object... urlVariables) {
52-
super(HttpMethod.POST, urlTemplate, urlVariables);
51+
MockMultipartHttpServletRequestBuilder(String urlTemplate, Object... uriVariables) {
52+
super(HttpMethod.POST, urlTemplate, uriVariables);
5353
super.contentType(MediaType.MULTIPART_FORM_DATA);
5454
}
5555

Diff for: spring-test/src/main/java/org/springframework/test/web/servlet/request/MockMvcRequestBuilders.java

+29-29
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2015 the original author or authors.
2+
* Copyright 2002-2016 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -49,10 +49,10 @@ public abstract class MockMvcRequestBuilders {
4949
/**
5050
* Create a {@link MockHttpServletRequestBuilder} for a GET request.
5151
* @param urlTemplate a URL template; the resulting URL will be encoded
52-
* @param urlVariables zero or more URL variables
52+
* @param uriVars zero or more URI variables
5353
*/
54-
public static MockHttpServletRequestBuilder get(String urlTemplate, Object... urlVariables) {
55-
return new MockHttpServletRequestBuilder(HttpMethod.GET, urlTemplate, urlVariables);
54+
public static MockHttpServletRequestBuilder get(String urlTemplate, Object... uriVars) {
55+
return new MockHttpServletRequestBuilder(HttpMethod.GET, urlTemplate, uriVars);
5656
}
5757

5858
/**
@@ -67,10 +67,10 @@ public static MockHttpServletRequestBuilder get(URI uri) {
6767
/**
6868
* Create a {@link MockHttpServletRequestBuilder} for a POST request.
6969
* @param urlTemplate a URL template; the resulting URL will be encoded
70-
* @param urlVariables zero or more URL variables
70+
* @param uriVars zero or more URI variables
7171
*/
72-
public static MockHttpServletRequestBuilder post(String urlTemplate, Object... urlVariables) {
73-
return new MockHttpServletRequestBuilder(HttpMethod.POST, urlTemplate, urlVariables);
72+
public static MockHttpServletRequestBuilder post(String urlTemplate, Object... uriVars) {
73+
return new MockHttpServletRequestBuilder(HttpMethod.POST, urlTemplate, uriVars);
7474
}
7575

7676
/**
@@ -85,10 +85,10 @@ public static MockHttpServletRequestBuilder post(URI uri) {
8585
/**
8686
* Create a {@link MockHttpServletRequestBuilder} for a PUT request.
8787
* @param urlTemplate a URL template; the resulting URL will be encoded
88-
* @param urlVariables zero or more URL variables
88+
* @param uriVars zero or more URI variables
8989
*/
90-
public static MockHttpServletRequestBuilder put(String urlTemplate, Object... urlVariables) {
91-
return new MockHttpServletRequestBuilder(HttpMethod.PUT, urlTemplate, urlVariables);
90+
public static MockHttpServletRequestBuilder put(String urlTemplate, Object... uriVars) {
91+
return new MockHttpServletRequestBuilder(HttpMethod.PUT, urlTemplate, uriVars);
9292
}
9393

9494
/**
@@ -103,10 +103,10 @@ public static MockHttpServletRequestBuilder put(URI uri) {
103103
/**
104104
* Create a {@link MockHttpServletRequestBuilder} for a PATCH request.
105105
* @param urlTemplate a URL template; the resulting URL will be encoded
106-
* @param urlVariables zero or more URL variables
106+
* @param uriVars zero or more URI variables
107107
*/
108-
public static MockHttpServletRequestBuilder patch(String urlTemplate, Object... urlVariables) {
109-
return new MockHttpServletRequestBuilder(HttpMethod.PATCH, urlTemplate, urlVariables);
108+
public static MockHttpServletRequestBuilder patch(String urlTemplate, Object... uriVars) {
109+
return new MockHttpServletRequestBuilder(HttpMethod.PATCH, urlTemplate, uriVars);
110110
}
111111

112112
/**
@@ -121,10 +121,10 @@ public static MockHttpServletRequestBuilder patch(URI uri) {
121121
/**
122122
* Create a {@link MockHttpServletRequestBuilder} for a DELETE request.
123123
* @param urlTemplate a URL template; the resulting URL will be encoded
124-
* @param urlVariables zero or more URL variables
124+
* @param uriVars zero or more URI variables
125125
*/
126-
public static MockHttpServletRequestBuilder delete(String urlTemplate, Object... urlVariables) {
127-
return new MockHttpServletRequestBuilder(HttpMethod.DELETE, urlTemplate, urlVariables);
126+
public static MockHttpServletRequestBuilder delete(String urlTemplate, Object... uriVars) {
127+
return new MockHttpServletRequestBuilder(HttpMethod.DELETE, urlTemplate, uriVars);
128128
}
129129

130130
/**
@@ -139,10 +139,10 @@ public static MockHttpServletRequestBuilder delete(URI uri) {
139139
/**
140140
* Create a {@link MockHttpServletRequestBuilder} for an OPTIONS request.
141141
* @param urlTemplate a URL template; the resulting URL will be encoded
142-
* @param urlVariables zero or more URL variables
142+
* @param uriVars zero or more URI variables
143143
*/
144-
public static MockHttpServletRequestBuilder options(String urlTemplate, Object... urlVariables) {
145-
return new MockHttpServletRequestBuilder(HttpMethod.OPTIONS, urlTemplate, urlVariables);
144+
public static MockHttpServletRequestBuilder options(String urlTemplate, Object... uriVars) {
145+
return new MockHttpServletRequestBuilder(HttpMethod.OPTIONS, urlTemplate, uriVars);
146146
}
147147

148148
/**
@@ -157,11 +157,11 @@ public static MockHttpServletRequestBuilder options(URI uri) {
157157
/**
158158
* Create a {@link MockHttpServletRequestBuilder} for a HEAD request.
159159
* @param urlTemplate a URL template; the resulting URL will be encoded
160-
* @param urlVariables zero or more URL variables
160+
* @param uriVars zero or more URI variables
161161
* @since 4.1
162162
*/
163-
public static MockHttpServletRequestBuilder head(String urlTemplate, Object... urlVariables) {
164-
return new MockHttpServletRequestBuilder(HttpMethod.HEAD, urlTemplate, urlVariables);
163+
public static MockHttpServletRequestBuilder head(String urlTemplate, Object... uriVars) {
164+
return new MockHttpServletRequestBuilder(HttpMethod.HEAD, urlTemplate, uriVars);
165165
}
166166

167167
/**
@@ -175,12 +175,12 @@ public static MockHttpServletRequestBuilder head(URI uri) {
175175

176176
/**
177177
* Create a {@link MockHttpServletRequestBuilder} for a request with the given HTTP method.
178-
* @param httpMethod the HTTP method
178+
* @param method the HTTP method (GET, POST, etc)
179179
* @param urlTemplate a URL template; the resulting URL will be encoded
180-
* @param urlVariables zero or more URL variables
180+
* @param uriVars zero or more URI variables
181181
*/
182-
public static MockHttpServletRequestBuilder request(HttpMethod httpMethod, String urlTemplate, Object... urlVariables) {
183-
return new MockHttpServletRequestBuilder(httpMethod, urlTemplate, urlVariables);
182+
public static MockHttpServletRequestBuilder request(HttpMethod method, String urlTemplate, Object... uriVars) {
183+
return new MockHttpServletRequestBuilder(method, urlTemplate, uriVars);
184184
}
185185

186186
/**
@@ -196,10 +196,10 @@ public static MockHttpServletRequestBuilder request(HttpMethod httpMethod, URI u
196196
/**
197197
* Create a {@link MockMultipartHttpServletRequestBuilder} for a multipart request.
198198
* @param urlTemplate a URL template; the resulting URL will be encoded
199-
* @param urlVariables zero or more URL variables
199+
* @param uriVars zero or more URI variables
200200
*/
201-
public static MockMultipartHttpServletRequestBuilder fileUpload(String urlTemplate, Object... urlVariables) {
202-
return new MockMultipartHttpServletRequestBuilder(urlTemplate, urlVariables);
201+
public static MockMultipartHttpServletRequestBuilder fileUpload(String urlTemplate, Object... uriVars) {
202+
return new MockMultipartHttpServletRequestBuilder(urlTemplate, uriVars);
203203
}
204204

205205
/**

Diff for: spring-web/src/main/java/org/springframework/web/client/AsyncRestTemplate.java

+11-11
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2015 the original author or authors.
2+
* Copyright 2002-2016 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -206,11 +206,11 @@ public <T> ListenableFuture<ResponseEntity<T>> getForEntity(String url, Class<T>
206206

207207
@Override
208208
public <T> ListenableFuture<ResponseEntity<T>> getForEntity(String url, Class<T> responseType,
209-
Map<String, ?> urlVariables) throws RestClientException {
209+
Map<String, ?> uriVariables) throws RestClientException {
210210

211211
AsyncRequestCallback requestCallback = acceptHeaderRequestCallback(responseType);
212212
ResponseExtractor<ResponseEntity<T>> responseExtractor = responseEntityExtractor(responseType);
213-
return execute(url, HttpMethod.GET, requestCallback, responseExtractor, urlVariables);
213+
return execute(url, HttpMethod.GET, requestCallback, responseExtractor, uriVariables);
214214
}
215215

216216
@Override
@@ -371,13 +371,13 @@ public ListenableFuture<?> put(URI url, HttpEntity<?> request) throws RestClient
371371
// DELETE
372372

373373
@Override
374-
public ListenableFuture<?> delete(String url, Object... urlVariables) throws RestClientException {
375-
return execute(url, HttpMethod.DELETE, null, null, urlVariables);
374+
public ListenableFuture<?> delete(String url, Object... uriVariables) throws RestClientException {
375+
return execute(url, HttpMethod.DELETE, null, null, uriVariables);
376376
}
377377

378378
@Override
379-
public ListenableFuture<?> delete(String url, Map<String, ?> urlVariables) throws RestClientException {
380-
return execute(url, HttpMethod.DELETE, null, null, urlVariables);
379+
public ListenableFuture<?> delete(String url, Map<String, ?> uriVariables) throws RestClientException {
380+
return execute(url, HttpMethod.DELETE, null, null, uriVariables);
381381
}
382382

383383
@Override
@@ -518,17 +518,17 @@ public <T> ListenableFuture<ResponseEntity<T>> exchange(URI url, HttpMethod meth
518518

519519
@Override
520520
public <T> ListenableFuture<T> execute(String url, HttpMethod method, AsyncRequestCallback requestCallback,
521-
ResponseExtractor<T> responseExtractor, Object... urlVariables) throws RestClientException {
521+
ResponseExtractor<T> responseExtractor, Object... uriVariables) throws RestClientException {
522522

523-
URI expanded = getUriTemplateHandler().expand(url, urlVariables);
523+
URI expanded = getUriTemplateHandler().expand(url, uriVariables);
524524
return doExecute(expanded, method, requestCallback, responseExtractor);
525525
}
526526

527527
@Override
528528
public <T> ListenableFuture<T> execute(String url, HttpMethod method, AsyncRequestCallback requestCallback,
529-
ResponseExtractor<T> responseExtractor, Map<String, ?> urlVariables) throws RestClientException {
529+
ResponseExtractor<T> responseExtractor, Map<String, ?> uriVariables) throws RestClientException {
530530

531-
URI expanded = getUriTemplateHandler().expand(url, urlVariables);
531+
URI expanded = getUriTemplateHandler().expand(url, uriVariables);
532532
return doExecute(expanded, method, requestCallback, responseExtractor);
533533
}
534534

0 commit comments

Comments
 (0)