Skip to content

Commit 5b3ae76

Browse files
committed
polish javadoc and fixmes
1 parent 1f87111 commit 5b3ae76

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

framework-docs/modules/ROOT/pages/integration/scheduling.adoc

+3-4
Original file line numberDiff line numberDiff line change
@@ -499,10 +499,9 @@ seconds:
499499
[NOTE]
500500
====
501501
When destroying the annotated bean or closing the application context Spring Framework cancels
502-
scheduled tasks, which includes the next scheduled subscription to the `Publisher`.
503-
However, there is no tracking of individual subscriptions: once a subscription has started
504-
it can't be cancelled. For that reason, it is a pre-requisite that the `Publisher` is finite
505-
in addition to supporting multiple subsequent subscriptions.
502+
scheduled tasks, which includes the next scheduled subscription to the `Publisher` as well
503+
as any past subscription that is still currently active (e.g. for long-running publishers,
504+
or even infinite publishers).
506505
====
507506

508507

spring-context/src/main/java/org/springframework/scheduling/annotation/Scheduled.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@
3838
*
3939
* <p>Methods that return a reactive {@code Publisher} or a type which can be adapted
4040
* to {@code Publisher} by the default {@code ReactiveAdapterRegistry} are supported.
41-
* The {@code Publisher} MUST be finite and MUST support multiple subsequent subscriptions
42-
* (i.e. be cold).
41+
* The {@code Publisher} MUST support multiple subsequent subscriptions (i.e. be cold).
4342
* The returned Publisher is only produced once, and the scheduling infrastructure
4443
* then periodically {@code subscribe()} to it according to configuration.
4544
* Values emitted by the publisher are ignored. Errors are logged at WARN level, which

spring-context/src/test/java/org/springframework/scheduling/annotation/ScheduledAnnotationReactiveSupportTests.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,7 @@ void rejectCantAccessMethod() {
9999
.withCause(new IllegalAccessException("expected"));
100100
}
101101

102-
//FIXME find a way to test the case with fixedDelay effectively turning into a fixedRate ?
103-
104-
//FIXME test createCheckpointPublisherFor uses Reactor and checkpoint operator
102+
//TODO find a way to test the case with fixedDelay effectively turning into a fixedRate ?
105103

106104
@Test
107105
void hasCheckpointToString() {

0 commit comments

Comments
 (0)