Skip to content

Commit ca820c9

Browse files
committed
Polishing contribution
Closes gh-33715
1 parent f35ed8d commit ca820c9

File tree

2 files changed

+9
-22
lines changed

2 files changed

+9
-22
lines changed

spring-web/src/main/java/org/springframework/web/util/RfcUriParser.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
* Parser for URI's based on RFC 3986 syntax.
3030
*
3131
* @author Rossen Stoyanchev
32-
* @author Yanming Zhou
3332
* @since 6.2
3433
*
3534
* @see <a href="https://www.rfc-editor.org/info/rfc3986">RFC 3986</a>

spring-web/src/test/java/org/springframework/web/util/UriComponentsBuilderTests.java

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -633,29 +633,17 @@ void buildAndExpandOpaque(ParserType parserType) {
633633
@ParameterizedTest // gh-33699
634634
@EnumSource(value = ParserType.class)
635635
void schemeVariableMixedCase(ParserType parserType) {
636-
URI uri = UriComponentsBuilder
637-
.fromUriString("{TheScheme}://example.org", parserType)
638-
.buildAndExpand(Map.of("TheScheme", "ws"))
639-
.toUri();
640-
assertThat(uri.toString()).isEqualTo("ws://example.org");
641-
642-
uri = UriComponentsBuilder
643-
.fromUriString("{TheScheme}s://example.org", parserType)
644-
.buildAndExpand(Map.of("TheScheme", "ws"))
645-
.toUri();
646-
assertThat(uri.toString()).isEqualTo("wss://example.org");
647636

648-
uri = UriComponentsBuilder
649-
.fromUriString("s{TheScheme}://example.org", parserType)
650-
.buildAndExpand(Map.of("TheScheme", "ws"))
651-
.toUri();
652-
assertThat(uri.toString()).isEqualTo("sws://example.org");
637+
BiConsumer<String, String> tester = (scheme, value) -> {
638+
URI uri = UriComponentsBuilder.fromUriString(scheme + "://example.org", parserType)
639+
.buildAndExpand(Map.of("TheScheme", value))
640+
.toUri();
641+
assertThat(uri.toString()).isEqualTo("wss://example.org");
642+
};
653643

654-
uri = UriComponentsBuilder
655-
.fromUriString("s{TheScheme}s://example.org", parserType)
656-
.buildAndExpand(Map.of("TheScheme", "ws"))
657-
.toUri();
658-
assertThat(uri.toString()).isEqualTo("swss://example.org");
644+
tester.accept("{TheScheme}", "wss");
645+
tester.accept("{TheScheme}s", "ws");
646+
tester.accept("ws{TheScheme}", "s");
659647
}
660648

661649
@ParameterizedTest

0 commit comments

Comments
 (0)