ExecutorCompletionService for Spring TaskExecutor [SPR-5341]

[spring-projects-issues]

Dave Syer opened SPR-5341 and commented

Add TaskExecutorCompletionService. It would be nice to be able to use the TaskExecutor abstraction in a CompletionService, since it has wider applicability than Executor from java.util.concurrent.

Another very useful feature which can be built in is the ability to throttle the tasks, so that at most N are pending execution at any time, causing the submit() method to block until one completes.

---

Attachments:

• TaskExecutorCompletionService.java (4.21 kB)
• TaskExecutorCompletionServiceTests.java (2.70 kB)

[spring-projects-issues]

Dave Syer commented

Attached simple implementation (TaskExecutorCompletionService.java) and test case.

[spring-projects-issues]

Juergen Hoeller commented

A separate CompletionService implementation shouldn't be necessary anymore since the TaskExecutor interface extends the standard Executor interface now. In 3.0 M2, we generally allow for mixing and matching java.util.concurrent facilties with Spring's concurrency facilities as far as possible. This includes supporting Callables and Futures in our AsyncTaskExecutor interface, adapting a standard ExecutorService on top of any TaskExecutor, and using a standalone ExecutorCompletionService in combination with any plain TaskExecutor when needed.

Juergen