Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring expression: please improve getValue() in CompositeStringExpression [SPR-5466] #10139

Closed
spring-projects-issues opened this issue Feb 7, 2009 · 1 comment
Closed

Spring expression: please improve getValue() in CompositeStringExpression [SPR-5466] #10139

spring-projects-issues opened this issue Feb 7, 2009 · 1 comment
Assignees
@jhoeller
Labels
type: enhancement A general enhancement
Milestone
3.0 M2

Comments

@spring-projects-issues
Copy link
Collaborator

Oliver Becker opened SPR-5466 and commented

The current implementation of CompositeStringExpression.getValue() (which simply calls append() on a StringBuffer) inserts "null" for null values and "[I@f34a65" (or similar) for arrays.

I think it would be better to call ObjectUtils.getDisplayString() for the value to be appended.
(Incidentally there is already a TODO in this method)

At least the String "null" should be omitted (as in other web frameworks).

Affects: 3.0 M1
@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Good point. Thanks for raising this!

Juergen

@spring-projects-issues spring-projects-issues added the type: enhancement A general enhancement label Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 M2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.0 M2
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues