Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Petclinic controllers to take full advantage of @MVC style [SPR-5488] #10160

Closed
spring-projects-issues opened this issue Feb 13, 2009 · 1 comment
Closed

Consolidate Petclinic controllers to take full advantage of @MVC style [SPR-5488] #10160

spring-projects-issues opened this issue Feb 13, 2009 · 1 comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: task A general task

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Feb 13, 2009 •
edited
Loading

Chris Beams opened SPR-5488 and commented

Petclinic currently has the following controllers:

AddOwnerForm
AddPetForm
AddVisitForm

ClinicController

EditOwnerForm
EditPetForm
FindOwnersForm

Even though these controllers have long since been migrated to @MVC annotations and away from SimpleFormController / MultiActionController extension, their granularity reflects their inheritance-based origins.

A much better layout can be acheived now, where most or all entity-related functions are consolidated in a dedicated Controller. Simply:

OwnerController
PetController
VisitController
VetController
etc..

This issue is a sub-task of #10156
@spring-projects-issues
Copy link
Collaborator Author

Chris Beams commented

No longer relevant

@spring-projects-issues spring-projects-issues added status: declined A suggestion or change that we don't feel we should currently apply type: task A general task labels Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spring-projects-issues