Skip to content

ConstructorArgumentValues returns collections with different order [SPR-5554] #10225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Mar 9, 2009 · 0 comments
Closed

ConstructorArgumentValues returns collections with different order [SPR-5554] #10225

spring-projects-issues opened this issue Mar 9, 2009 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
3.0 M3

Comments

@spring-projects-issues
Copy link
Collaborator

Costin Leau opened SPR-5554 and commented

ConstructorArgumentValues internally uses two collections - a map for indexed arguments and a linked list for unindexed ones. The problem is that the list returns the constructor arguments in the XML defined order while the map doesn't. This is inconsistent for the caller which has no way to discover the declaration order for the indexed arguments.
The fix is trivial - the HashMap needs to be changed to a LinkedHashMap to preserve the order (a change which is backwards compatible).

Affects: 2.5.6

Referenced from: commits 423c411
@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 M3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
3.0 M3
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues