Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eager validation for missing destroy methods [SPR-5602] #10273

Closed
spring-projects-issues opened this issue Mar 23, 2009 · 1 comment
Closed
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Costin Leau opened SPR-5602 and commented

Currently, destroy methods are being discovered and invoked during destruction and any validation errors are only logged. The behaviour is different from init method which are validated at startup. An improvement would be to have the same behaviour for destroy methods as well - i.e. incorrect or missing methods would throw exceptions at startup (rather then at shutdown).


Affects: 2.5.6

Referenced from: commits bcf6f23

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Alright, we're eagerly validating destroy methods now. Wasn't quite as straightforward to change as I thought, since our disposable adapter needs to remain serializable when being put into a persistent session... That required quite some reworking of our DisposableBeanAdapter.

Juergen

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 M3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants