SPEL: Inconsistent implementation of ReflectivePropertyResolver - canRead vs. read for null targets [SPR-5663]

[spring-projects-issues]

Oliver Becker opened SPR-5663 and commented

The method canRead() in org.springframework.expression.spel.support.ReflectivePropertyResolver returns false if target is null.
However, the method read() returns null for a null target. According to the contract specified by canRead it should throw an AccessException in this case.

---

Affects: 3.0 M2

Referenced from: commits d34a2c5

[spring-projects-issues]

Andy Clement commented

I'm guessing this doesn't actually affect anything you are doing - it is just an observation about the code?

The read() method won't be invoked if canRead() already said it can't read it.

Anyway, I've now fixed it to make them consistent (and consistent with write/canWrite).

tests added also (although I think ReflectivePropertyResolver could do with a few more since it is only at 74% coverage)