dot in URL breaks @PathVariable binding [SPR-5778]

[spring-projects-issues]

Kenny MacLeod opened SPR-5778 and commented

Take the following REST endpoint:

@RequestMapping("/lat/{latitude}/long/{longitude}")
public void testLatLong(@PathVariable String latitude, @PathVariable String longitude) {
	System.out.println("Latitude = " + latitude);
	System.out.println("Longitude = " + longitude);
}

If you hit this with the URL

/lat/123/long/456 

it works fine, with both variables binding as expected. If, however, you try

/lat/0.1/long/0.1

you get

Latitude='0.1', longitude='0'

The second dot in the URL is causing the trailing 1 to be stripped off somewhere, so that latitude is bound correctly, but longitude isn't.

If you add a trailing slash to the mapping (i.e. "/lat/{latitude}/long/{longitude}/") and add a trailing slash to the URL, it works fine.

This may be related to #8317, but that issue looks to have been corrupted somehow (affects M3, fixed for M3?)

---

Affects: 3.0 M3

1 votes, 3 watchers

[spring-projects-issues]

Kenny MacLeod commented

Sorry, that should've been #10307

[spring-projects-issues]

Arjen Poutsma commented

Added markup.

[spring-projects-issues]

Arjen Poutsma commented

This is an unfortunate side-effect of the implicit matching for .* in the DefaultAnnotationHandlerMapping. Basically, every RequestMapping you specify also matches for pattern.* and pattern/..

You can disable this setting by defining an explicit DefaultAnnotationHandlerMapping in your servlet context, and setting the useDefaultSuffixPattern to false (the default is true).

[spring-projects-issues]

Arjen Poutsma commented

Reopened because of wrong resolution.

[spring-projects-issues]

Giridhar Nandigam commented

Arjen,

Will this issue not be fixed or is it resolved?

[spring-projects-issues]

Giridhar Nandigam commented

The resolution is to use useDefaultSuffixPattern = false on DefaultAnnotationHandlerMapping.

Mis-understood by wrong resolution.