Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the documentation to include the advice of using within() together with lone kinded pointcuts [SPR-6123] #10791

Closed
spring-projects-issues opened this issue Sep 18, 2009 · 1 comment
Assignees
Labels
type: documentation A documentation task type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Andrei Stefan opened SPR-6123 and commented

A large number of ShadowMatchImpls objects are created and cached in case a simple execution() pointcut is used. In case this pointcut is combined with a within() clause, as pointed out here: http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg10969.html, the problem goes away, since the method matching in beans is stricter.

It would be good to reflect this advice in the Spring documentation, as well.


Affects: 2.0.8, 2.5.6, 3.0 M4

Referenced from: commits 10e26e6

@spring-projects-issues
Copy link
Collaborator Author

Andy Clement commented

Fixed. Added to the end of the AOP section 7.2 'Declaring a pointcut', a new short section called 'Writing good pointcuts'.

Similar advice now also online with AspectJ at the end of this page: http://eclipse.org/aspectj/doc/released/progguide/language-joinPoints.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants