GenericConversionService calls initGenericConverters from constructor [SPR-6149]

[spring-projects-issues]

Marten Deinum opened SPR-6149 and commented

This actually arised as a WebFlow issue not sure if I need to register one for that also.

Basically when you need your own ConversionService and you extend the GenericConversionService and you need some depenencies injected those aren't available in the overriden initGenericConverters because it is called from the parents constructor. IMHO it would be more spring like that this method was called after all dependencies where injected so let it implement InitializingBean and implement the afterPropertiesSet method. That way it would work and would be more elegant imho.

---

Affects: 3.0 M4

Reference URL: http://forum.springsource.org/showthread.php?t=78098

[spring-projects-issues]

Juergen Hoeller commented

Good point. I removed those protected converter initialization hooks completely since it doesn't make much sense to override them. Subclasses should rather add further converters in their own constructors, or in their afterPropertiesSet method if they prefer.

Juergen